D12538: Always prompt for overwrite on double-click in save dialog

anemeth added a comment. In D12538#254871 , @rkflx wrote: > However, for double click mode and Save, descending into directories is kinda broken. You might want to fix that before shipping… REPOSITORY R241 KIO REVISION DETAIL https://phabri

D12538: Always prompt for overwrite on double-click in save dialog

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: ltoscano, rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Always prompt for overwrite on double-click in save dialog

anemeth marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: ltoscano, rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Always prompt for overwrite on double-click in save dialog

anemeth updated this revision to Diff 3. anemeth added a comment. - Merge branch 'master' of https://github.com/KDE/kio into doubleclick_save - reword comment - move function definition REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33204&id=33

D12538: Always prompt for overwrite on double-click in save dialog

rkflx added a comment. TBH, I don't get what the overwrite and release schedule discussion has to do with this patch. All it does is add an additional method to trigger `slotOk()`, i.e. instead of clicking on Save, users can simply double-click. The fact that either the dialog or the app

D12538: Always prompt for overwrite on double-click in save dialog

ngraham added a comment. It will always work properly, it's just a question of how users will be annoyed. :) FWIW right now with the status quo, Kate users are faced with two annoyances: - Double-clicking on a file doesn't trigger overwrite - Once the overwrite confirmation dialog appe

D12538: Always prompt for overwrite on double-click in save dialog

ltoscano added a comment. Whatever happens, just consider that it's always possible (and it will happen) for users to use a newer KIO with an older Kate; so regardless of the Kate patch, this case should work properly. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D125

D12538: Always prompt for overwrite on double-click in save dialog

ngraham added a comment. In D12538#255184 , @ltoscano wrote: > In D12538#255183 , @ngraham wrote: > > > In D12538#255101 , @ltoscano wrote: > > > > > D

D12538: Always prompt for overwrite on double-click in save dialog

ltoscano added a comment. In D12538#255183 , @ngraham wrote: > In D12538#255101 , @ltoscano wrote: > > > Does it work if a newer KIO is used with an older version of those applications? > > >

D12538: Always prompt for overwrite on double-click in save dialog

ngraham added a comment. In D12538#255101 , @ltoscano wrote: > In D12538#255048 , @ngraham wrote: > > > We still need to fix Kate's save dialog before we can land this, because right now it handles

D12538: Always prompt for overwrite on double-click in save dialog

ltoscano added a comment. In D12538#255048 , @ngraham wrote: > We still need to fix Kate's save dialog before we can land this, because right now it handles the overwrite case itself rather than delegating to the dialog like most KDE apps do. An

D12538: Always prompt for overwrite on double-click in save dialog

ngraham added a comment. We still need to fix Kate's save dialog before we can land this, because right now it handles the overwrite case itself rather than delegating to the dialog like most KDE apps do. And we should do a sweep of other KDE apps that also have this legacy behavior left ove

D12538: Always prompt for overwrite on double-click in save dialog

ngraham retitled this revision from "Select item without clicking the Open/Save button" to "Always prompt for overwrite on double-click in save dialog". ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #framewor