D12512: ScrollViewKCM

This revision was automatically updated to reflect the committed changes. Closed by commit R296:c175bbfc8861: ScrollViewKCM (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12512?vs=33111&id=33141 REVISION DETAIL https://phabricator.kd

D12512: ScrollViewKCM

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH mart/ScrollViewKCM REVISION DETAIL https://phabricator.kde.org/D12512 To: mart, #plasma, hein Cc: hein, #frameworks, michaelh, bruns

D12512: ScrollViewKCM

mart updated this revision to Diff 33111. mart added a comment. - use paddings from Control REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12512?vs=33049&id=33111 BRANCH mart/ScrollViewKCM REVISION DETAIL https://phabricator.kde.org/D12512 AFFEC

D12512: ScrollViewKCM

hein added a comment. It looks good otherwise and I really want to accept this so I can progress on the Language KCM, but this magic value thing gives me a headache. It's going to break with other QStyles with a different value. We need some sort of fix for that ... REPOSITORY R296 KDecla

D12512: ScrollViewKCM

mart added a comment. to be used with https://phabricator.kde.org/D12515 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D12512 To: mart, #plasma Cc: hein, #frameworks, michaelh, bruns

D12512: ScrollViewKCM

mart added a comment. In D12512#253498 , @hein wrote: > Does the magic pixel size number for the padding get scaled correctly on hidpi? on the current way we have to scale in the kcm yes, it will be scaled > And where does System Set

D12512: ScrollViewKCM

hein added a comment. Does the magic pixel size number for the padding get scaled correctly on hidpi? And where does System Settings have the magic pixel number from - is it hardcoded there as well or is it a QStyle thing that could change with the style engine? Could System Settin

D12512: ScrollViewKCM

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mart requested review of this revision. REVISION SUMMARY ScrollViewKCM component to be used when a kcm has a main component which