D12490: concatPaths: process empty path1 correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R241:47340d6a554c: concatPaths: process empty path1 correctly (authored by aleksejshilin). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12490?vs=32961&id=33260 REVISION D

D12490: concatPaths: process empty path1 correctly

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, so concatPaths returns absolute paths if path1 is absolute, and relative paths if path1 is relative. Makes sense, but should be documented. REPOSITORY R241 KIO BRANCH fix_concatPat

D12490: concatPaths: process empty path1 correctly

anthonyfieroni added a comment. > Q_ASSERT(!path2.startsWith(QLatin1Char('/'))); If path1 is empty path2 will point to full path not absolute e.g. /something it should be ./something. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12490 To: aleksejshilin, #framewo

D12490: concatPaths: process empty path1 correctly

aleksejshilin added a comment. In D12490#252959 , @anthonyfieroni wrote: > path1 *should* never be empty Hm... I thought concatPaths() is supposed to be used like this: `concatPaths(basePath, relativePath)` - then an empty basePath makes

D12490: concatPaths: process empty path1 correctly

anthonyfieroni added a comment. path1 *should* never be empty REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12490 To: aleksejshilin, #frameworks, anthonyfieroni, dfaure Cc: michaelh, bruns

D12490: concatPaths: process empty path1 correctly

aleksejshilin added reviewers: anthonyfieroni, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12490 To: aleksejshilin, #frameworks, anthonyfieroni, dfaure Cc: michaelh, bruns

D12490: concatPaths: process empty path1 correctly

aleksejshilin requested review of this revision. aleksejshilin added a comment. Here is an example of KUrlCompletion breakage. Before, it returned invalid absolute paths like /Desktop etc.: F5820341: Before.png After: F5820340: After.png

D12490: concatPaths: process empty path1 correctly

aleksejshilin created this revision. aleksejshilin added a reviewer: Frameworks. Restricted Application added a project: Frameworks. aleksejshilin requested review of this revision. REVISION SUMMARY When path1 was empty (i.e. 'current directory'), concatPaths() used to return an absolute path

D12490: concatPaths: process empty path1 correctly

aleksejshilin planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12490 To: aleksejshilin, #frameworks Cc: michaelh, bruns