D12385: Thumbnail smooth scaling in filepicker

anemeth closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg, ngraham, elvisangelaccio, rkflx Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

ngraham added a comment. Seems like nobody has any objections. Wanna land this, @anemeth? REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg, ngraham, elvisangelaccio, rkflx Cc: cfe

D12385: Thumbnail smooth scaling in filepicker

ngraham added a comment. Any objections to landing this tomorrow if we don't hear any objections from #frameworks people before then? REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabrica

D12385: Thumbnail smooth scaling in filepicker

ngraham added a comment. #frameworks or @elvisangelaccio, any objections, or can we land this soon? REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #

D12385: Thumbnail smooth scaling in filepicker

rkflx accepted this revision. rkflx added a comment. Thanks Kai, great questions. I think I can answer them: In D12385#250511 , @broulik wrote: > What's the performance penalty of that? I don't see any performance issues, both when te

D12385: Thumbnail smooth scaling in filepicker

ngraham added reviewers: elvisangelaccio, rkflx. REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg, ngraham, elvisangelaccio, rkflx Cc: cfeck, broulik, ngraham, #frameworks, michaelh,

D12385: Thumbnail smooth scaling in filepicker

anemeth added a comment. Ping. We are scaling 128px icons to lower sizes. In this case smooth transformation does not really affect performance. Can someone confirm that this is the right approach? REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DE

D12385: Thumbnail smooth scaling in filepicker

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Definitely a visual improvement! Let's wait for a few more opinions regarding whether this is the right approach technically. REPOSITORY R241 KIO BRANCH image_smooth_downscale (branc

D12385: Thumbnail smooth scaling in filepicker

anemeth added a comment. I hit the resizing performance issue without this patch too, so it's unrelated to this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

ngraham added a comment. I too cannot reproduce the performance issue, even after nuking `~/.cache/thumbnails` and having it regenerate the thumbnails. Can you, @cfeck? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: cfeck, broul

D12385: Thumbnail smooth scaling in filepicker

cfeck added a comment. The XDG thumbnail spec has two thumbnail sizes, 128 and 256. It is possible that you hit the "slow" issue when only one size of thumbnail had been created, but the other was still pending. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To:

D12385: Thumbnail smooth scaling in filepicker

anemeth added a comment. BTW I don't know what caused the performance issue when moving the slider before, maybe something heavy was running in the background, but I can't reproduce the problem anymore. F5815440: 2018-04-20 21-45-19.webm REPOSITORY

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32675. anemeth added a comment. Remove debug REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32674&id=32675 BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D123

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32674. anemeth added a comment. Revert resize change. Turns out the image we got here is already downsized to around 128x128 and we further downsize it (if needed), dependent on the icon size. Working with this small images the smooth scaling should

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32672. anemeth added a comment. Remove debug REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32671&id=32672 BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D123

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32671. anemeth added a comment. @ngraham good advice Smooth scale the fast downscaled image for good performance REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32657&id=32671 BRANCH image_smooth_downscale (bra

D12385: Thumbnail smooth scaling in filepicker

ngraham added a comment. Could we use the fast scaling while resizing, then change to the smooth scaling once the resize operation is done? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: broulik, ngraham, #frameworks, michaelh,

D12385: Thumbnail smooth scaling in filepicker

anemeth planned changes to this revision. anemeth added a comment. In D12385#250511 , @broulik wrote: > What's the performance penalty of that? Does the file dialog request the correct size from the preview job? It shouldn't have to end up in thi

D12385: Thumbnail smooth scaling in filepicker

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: broulik, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

broulik added a comment. What's the performance penalty of that? Does the file dialog request the correct size from the preview job? It shouldn't have to end up in this codepath that often, I //think//. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth,

D12385: Thumbnail smooth scaling in filepicker

anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32657. anemeth added a comment. Remove accidental left in change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32655&id=32657 BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phab

D12385: Thumbnail smooth scaling in filepicker

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.