D12291: Accept file descriptor only from root owned process

chinmoyr abandoned this revision. chinmoyr added a comment. As of now this change is not of any importance. If in future a situation arises where we need it I will reopen this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12291 To: chinmoyr, #frameworks, dfa

D12291: Accept file descriptor only from root owned process

chinmoyr updated this revision to Diff 35010. chinmoyr added a comment. Accept socket connection where getsockopt() is not present REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12291?vs=34966&id=35010 BRANCH master REVISION DETAIL https://phabricator.kde

D12291: Accept file descriptor only from root owned process

ossi added inline comments. INLINE COMMENTS > chinmoyr wrote in fdreceiver.cpp:89 > > i don't see why that would be horrible > > I meant adding "acceptConnection = true;" after #warning would look weird. > Obviously that's not even an issue and I shouldn't have mentioned it. > > There is a dis

D12291: Accept file descriptor only from root owned process

chinmoyr added inline comments. INLINE COMMENTS > ossi wrote in fdreceiver.cpp:89 > i don't see why that would be horrible; as i pointed out multiple times > already, this change is redundant. one correction, though: add a code comment > here rather than extending the commit message. > > getso

D12291: Accept file descriptor only from root owned process

ossi added inline comments. INLINE COMMENTS > chinmoyr wrote in fdreceiver.cpp:89 > I don't think making acceptConnection unconditionally true is a good idea. At > least it will make this patch look horrible. > Since getsocketopt conforms to posix, how about we check for __ unix __ , and > posi

D12291: Accept file descriptor only from root owned process

chinmoyr added inline comments. INLINE COMMENTS > ossi wrote in fdreceiver.cpp:89 > i wonder whether that shouldn't come with an unconditional acceptConnection = > true; then - now the compilation succeeds, but it will fail to operate. given > that the whole feature is redundant with moving the

D12291: Accept file descriptor only from root owned process

ossi added inline comments. INLINE COMMENTS > fdreceiver.cpp:89 > +#else > +#warning Cannot get socket credentials! > +#endif i wonder whether that shouldn't come with an unconditional acceptConnection = true; then - now the compilation succeeds, but it will fail to operate. given that the who

D12291: Accept file descriptor only from root owned process

ossi accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12291 To: chinmoyr, #frameworks, dfaure, ossi Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

chinmoyr added a comment. @ossi would you mind reviewing this patch? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12291 To: chinmoyr, #frameworks, dfaure Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

chinmoyr updated this revision to Diff 34966. chinmoyr added a comment. Restricted Application added a subscriber: kde-frameworks-devel. I only realized now that after making the previous change I forgot to rebase. So uploading correct patch. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D12291: Accept file descriptor only from root owned process

chinmoyr updated this revision to Diff 33776. chinmoyr marked an inline comment as done. chinmoyr added a comment. Updated the comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12291?vs=32410&id=33776 BRANCH master REVISION DETAIL https://phabricator

D12291: Accept file descriptor only from root owned process

ossi added a comment. as i certainly mentioned somewhere else already, this is redundant with putting the socket in a safe place. but fair enough ... INLINE COMMENTS > fdreceiver.cpp:67 > if (client > 0) { > -FDMessageHeader msg; > -if (::recvmsg(client, msg.message(), 0

D12291: Accept file descriptor only from root owned process

chinmoyr created this revision. chinmoyr added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Limiting file ioslave to recieve file descriptor only from root owned process helps to make sure that