D12271: Don't remove trailing whitespace from cursor line

cullmann commandeered this revision. cullmann edited reviewers, added: sraizada; removed: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12271 To: cullmann, #ktexteditor, dhaumann, sraizada Cc: cullmann, kwrite-devel, kde-frameworks-devel, dhaumann, anthony

D12271: Don't remove trailing whitespace from cursor line

cullmann abandoned this revision. cullmann added a comment. > as said, we don't want that behavior change, sorry for that. == REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12271 To: cullmann, #ktexted

D12271: Don't remove trailing whitespace from cursor line

cullmann requested changes to this revision. cullmann added a comment. > I agree that the current state is ok and we arrived there after X iterations. I can agree that it might be bad for people with the habit to save each 5 seconds, but actually, given we have swap files for crash recovery,

D12271: Don't remove trailing whitespace from cursor line

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. See arguments above: If we change it, another one will come over time

D12271: Don't remove trailing whitespace from cursor line

dhaumann added a comment. @sraizada I am just seeing that this is your first KDE patch, nice! I hope that you do not get discouraged by my comments, I am just trying to find good solutions that work for everyone, and in this case, the solution this patch proposed did not work out in the past

D12271: Don't remove trailing whitespace from cursor line

dhaumann added a comment. The behavior that is proposed here was like Kate behaved before, and as result we got bug reports that not all trailing spaces were removed. So we removed this. I can see that when saving very often, this may be annoying. On the other hand, the current behavior

D12271: Don't remove trailing whitespace from cursor line

sraizada added a comment. Would it be appropriate to add this as a config option in the settings? Because to me, keeping the sort of whitespace you describe seems like the better behavior: doSomething(a, b, | ^ is correct. But obviously there are differing opinions on this, and a setting

D12271: Don't remove trailing whitespace from cursor line

anthonyfieroni added a comment. But if you do this do_work(); | will not remove trailling space after ';' before corsor. You should explicit chaeck that you have only whitespace on the line. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12271 To: sr

D12271: Don't remove trailing whitespace from cursor line

sraizada added a comment. Forgot to put this in the first submission: it fails test 66 vimode_keys, I believe this may be related to bug 392858 - vi mode :q (quit) command works in Kate but not KWrite https://bugs.kde.org/show_bug.cgi?id=392858 Every other test passes. REPOSITORY R39 KTe

D12271: Don't remove trailing whitespace from cursor line

sraizada created this revision. sraizada added a reviewer: KTextEditor. sraizada added a project: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. sraizada requested review of this revision. REVISION SUMMARY When the 're