This revision was automatically updated to reflect the committed changes.
Closed by commit R127:4705c38ff12b: Add XDG Output Protocol (authored by
davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12235?vs=34190&id=34201
REVISION DETAIL
https
romangg accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12235
To: davidedmundson, romangg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson updated this revision to Diff 34190.
davidedmundson added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel;
removed: Frameworks.
Add check for if values haven't really changed
Renamed a var
A few more comments
REPOSITORY
R127 KWayland
CHA
davidedmundson added inline comments.
INLINE COMMENTS
> romangg wrote in xdgoutput_interface.cpp:83
> This variable is only relevant until the compositor has sent for the first
> time the done event via `XdgOutputInterface::done()`. Afterwards it is always
> true. Is it meant this way? If yes,
romangg added inline comments.
INLINE COMMENTS
> romangg wrote in xdgoutput_interface.cpp:83
> This variable is only relevant until the compositor has sent for the first
> time the done event via `XdgOutputInterface::done()`. Afterwards it is always
> true. Is it meant this way? If yes, could w
romangg added a comment.
According to protocol the logical size and position events should only be send
(i) on creation of an xdg_output object and
(ii) when the size or position changed.
There is currently no check in the server interface, if the size and position
really changed w
davidedmundson updated this revision to Diff 33341.
davidedmundson added a comment.
Fixes
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12235?vs=32266&id=33341
BRANCH
davidedmundson/xdgoutput
REVISION DETAIL
https://phabricator.kde.org/D12235
AFFEC
davidedmundson marked 4 inline comments as done.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D12235
To: davidedmundson, romangg
Cc: #frameworks, michaelh, bruns
romangg added inline comments.
INLINE COMMENTS
> display.h:263
> +/**
> + * Creates the ServerSideDecorationPaletteManagerInterface
> + *
the //XdgOutputManagerInterface//
> xdgoutput_interface.cpp:107
> +});
> +connect(this, &QObject::destroyed, this, [this, output]
davidedmundson added a comment.
> Replace XDGOUTPUTVERSION with the next framework release version.
I will do that when merging as I don't know at time of review what version
that is going to be.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D12235
To: davide
romangg added a comment.
- Replace `XDGOUTPUTVERSION` with the next framework release version.
- xdgoutputtest.cpp is missing
INLINE COMMENTS
> registry.h:624
> + * Prefer using createXdgOutputManager instead.
> + * @see createXdgOutputUnstableV1
> + * @since 5.XDGOUTPUTVERSION
romangg added a task: T8501: Fractional Scaling.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D12235
To: davidedmundson, romangg
Cc: #frameworks, michaelh, ngraham, bruns
davidedmundson updated this revision to Diff 32266.
davidedmundson added a comment.
Some minor fixes
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12235?vs=32227&id=32266
BRANCH
davidedmundson/xdgoutput
REVISION DETAIL
https://phabricator.kde.org/D1
romangg added a reviewer: romangg.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D12235
To: davidedmundson, romangg
Cc: #frameworks, michaelh, ngraham, bruns
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
davidedmundson requested review of this revision.
REVISION SUMMARY
Done primarily for XWayland which for legacy reasons doesn't assume the
logical si
15 matches
Mail list logo
