D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham abandoned this revision. ngraham added a subscriber: anemeth. ngraham added a comment. Abandoning this revision in favor of the superior one that @anemeth submitted: D12306 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx, abetts Cc: abetts, cfeck, alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham updated this revision to Diff 32114. ngraham added a comment. Rebase on current master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12149?vs=32094&id=32114 BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 AFFECTED FILES

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

rkflx accepted this revision. rkflx added a comment. Thanks ;) Anybody from #Frameworks still having objections on code or behaviour? REPOSITORY R241 KIO BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 To: n

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx, abetts Cc: abetts, cfeck, alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham updated this revision to Diff 32094. ngraham added a comment. Slightly reduce the minimum width REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12149?vs=32017&id=32094 BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 AFFEC

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

rkflx added a comment. Ok, forget about Dolphin, which for small sizes IMO could be much more dense than it is now. However, can we still tweak the file dialog a bit? My issue is that between 16px and 72px there is absolutely no change in both the number of characters displayed, as

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

rkflx added a comment. @ngraham Before I look at this in detail: Did you aim for a spacing consistent with Dolphin? Because on a short try with different icon sizes in both Dolphin and the file dialog, sometimes one was wider and sometimes the other… REPOSITORY R241 KIO BRANCH tighter-

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

abetts accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH tighter-grid-in-icons-view (branched from master) REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx, abetts Cc: abetts, cfeck, alexeymin, micha

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

abetts added a comment. Can we also create another patch that can add more vertical spacing between the items and the top edge of the field? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: abetts, cfeck, alexeymin, michael

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: cfeck, alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: cfeck, alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham updated this revision to Diff 32017. ngraham added a comment. Take the font size into consideration with the minimum width REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12149?vs=31973&id=32017 BRANCH tighter-grid-in-icons-view (branched from master)

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham added inline comments. INLINE COMMENTS > cfeck wrote in kdiroperator.cpp:2590 > If you need a minimum width to accomodate a minimum number of characters, you > could use a value proportional to font size, e.g. "8 * metrics.height()" will > give you room for about 15 characters (they are

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: cfeck, alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

cfeck added inline comments. INLINE COMMENTS > kdiroperator.cpp:2590 > +// Set a minimum width to make enough room for a label when the > icons are tiny > +const QSize itemSize = QSize(qMax(120, width), height); > +view->setGridSize(itemSize); If you need a minimum width

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham added a comment. FWIW I wrestled with the issue prior to submitting the patch, but couldn't come up with anything better. The issue here that we really do need a minimum width of //at least// 110px or else there's simply never enough room for titles with small icons, but there's a la

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham added a comment. Yes, I'm afraid it's a magic number: the minimum width of each cell. I'm open to better approaches. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

alexeymin added a comment. New version looks much better, no doubt. The only thing you may be asked about here is magical number 120, what is it? Some minimum width for item? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc:

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx Cc: michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham created this revision. ngraham added reviewers: Frameworks, VDG, rkflx. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY This patch improves the grid spacing in icons-on-top mode by making it looser for small icons (which gi