D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham updated this revision to Diff 32030. ngraham added a comment. Use the more familiar and less technical string "File type" REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12130?vs=32018&id=32030 BRANCH file-format-label (branched from master) REVISION

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham marked an inline comment as done. ngraham added a comment. In D12130#245409 , @bruns wrote: > In D12130#245373 , @ngraham wrote: > > > Change the text only when saving (it really is a filter

D12130: Use the more user-friendly string "File format" in the save dialogs

ltoscano added a comment. In D12130#245409 , @bruns wrote: > In D12130#245373 , @ngraham wrote: > > > Change the text only when saving (it really is a filter bar in open mode) > > > Why not use

D12130: Use the more user-friendly string "File format" in the save dialogs

bruns added a comment. In D12130#245373 , @ngraham wrote: > Change the text only when saving (it really is a filter bar in open mode) Why not use "File formats" (plural) for the Open dialog? REPOSITORY R241 KIO REVISION DETAIL https:

D12130: Use the more user-friendly string "File format" in the save dialogs

bruns added inline comments. INLINE COMMENTS > ngraham wrote in kfilewidget.cpp:1338 > I've always said "save as." > > "Save that picture as a JPEG real fast, would ya?" "Use it to choose which format to use for saving"? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D121

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham marked 2 inline comments as done. ngraham added inline comments. INLINE COMMENTS > cfeck wrote in kfilewidget.cpp:1338 > Do you say "Save a file as a format" or "Save a file in a format"? I've always said "save as." "Save that picture as a JPEG real fast, would ya?" REPOSITORY R241 K

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham updated this revision to Diff 32018. ngraham marked 2 inline comments as done. ngraham added a comment. Improve the formatting, and move the label into its own function REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12130?vs=32015&id=32018 BRANCH fil

D12130: Use the more user-friendly string "File format" in the save dialogs

cfeck added inline comments. INLINE COMMENTS > kfilewidget.cpp:1334 > +QString filterWhatsThisText; > if (operationMode == KFileWidget::Saving) { > +locationWhatsThisText = "" + i18n("This is the name to save the > file as.") + I think with an empty line after the QString varia

D12130: Use the more user-friendly string "File format" in the save dialogs

ngraham retitled this revision from "Use the more user-friendly string "File format" in the open/save dialogs" to "Use the more user-friendly string "File format" in the save dialogs". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241