D12120: Check if the application androiddeployqt package has a main() symbol

This revision was automatically updated to reflect the committed changes. Closed by commit R240:8e2ce83987d2: Check if the application androiddeployqt package has a main() symbol (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12

D12120: Check if the application androiddeployqt package has a main() symbol

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Just tested that my 64bit host nm can also consume 32bit ARM binaries, seems to work, so not using the corresponding toolchain nm is probably fine here. REPOSITORY R240 Extra CMake Modu

D12120: Check if the application androiddeployqt package has a main() symbol

vatra added a comment. +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12120 To: apol, #frameworks, #build_system Cc: vatra, aacid, michaelh, ngraham, bruns

D12120: Check if the application androiddeployqt package has a main() symbol

apol added a comment. In D12120#244538 , @aacid wrote: > Is this going to fail on my translated nm output? Well it shouldn't, we're passing `LANG=C` which is what solved it for the other command, I don't see why nm should be any different

D12120: Check if the application androiddeployqt package has a main() symbol

aacid added a comment. Is this going to fail on my translated nm output? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12120 To: apol, #frameworks, #build_system Cc: aacid, michaelh, ngraham, bruns

D12120: Check if the application androiddeployqt package has a main() symbol

apol created this revision. apol added reviewers: Frameworks, Build System. Restricted Application added projects: Frameworks, Build System. apol requested review of this revision. REVISION SUMMARY Back in the KDE Edu sprint, we decided we need such a check, otherwise you get rather frustrated