D11907: advancedqueryparsertest: Add optimization test

michaelh updated this revision to Diff 31373. michaelh added a comment. - Rename testOptimizedLogic - Add a different testOptimizedLogic REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31230&id=31373 BRANCH advancedqueryparsertest (branched from

D11907: advancedqueryparsertest: Add optimization test

bruns added a comment. Although this is probably a useful addition (haven't checked which cases the existing unit test already cover), it does not cover the changes in D11826 . The code in https://cgit.kde.org/baloo.git/tree/src/lib/advancedqueryparse

D11907: advancedqueryparsertest: Add optimization test

bruns added inline comments. INLINE COMMENTS > advancedqueryparsertest.cpp:228 > +const QString nofail; > +QString phrase; > +phrase = QStringLiteral("a AND b AND c AND d"); better use a different name, phrase has a special meaning, i.e. Baloo:EngineQuery:Phrase REPOSITORY R293 B

D11907: advancedqueryparsertest: Add optimization test

michaelh added a comment. @bruns: This is mainly to confirm I understood D11826 correctly. The tests pass with or without your patch. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #framework

D11907: advancedqueryparsertest: Add optimization test

michaelh created this revision. michaelh added reviewers: Baloo, bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REPOSITORY R293 Baloo BRANCH advancedqueryparsertest (branched f