D11907: advancedqueryparsertest: Add more tests

This revision was automatically updated to reflect the committed changes. michaelh marked 3 inline comments as done. Closed by commit R293:1ea0b94497c3: advancedqueryparsertest: Add more tests (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D11907: advancedqueryparsertest: Add more tests

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Ok, this is ready now. Thanks! REPOSITORY R293 Baloo BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bru

D11907: advancedqueryparsertest: Add more tests

michaelh updated this revision to Diff 31519. michaelh added a comment. - Distinguish tests REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31518&id=31519 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL https://phabricator.

D11907: advancedqueryparsertest: Add more tests

michaelh added a comment. $ ctest -R advanced -V F5795958: AdvancedQueryParserTest REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoo

D11907: advancedqueryparsertest: Add more tests

michaelh updated this revision to Diff 31518. michaelh added a comment. - Add 'fallback' test REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31512&id=31518 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL https://phabricato

D11907: advancedqueryparsertest: Add more tests

bruns added a comment. Can you add the output of the failing tests here verbatim? INLINE COMMENTS > michaelh wrote in advancedqueryparsertest.cpp:264 > This test fails. "no optimization" serves as a flag, that it's expected to > fail and as message why. See lines 217-219. That's why I though

D11907: advancedqueryparsertest: Add more tests

michaelh marked 4 inline comments as done. michaelh added inline comments. INLINE COMMENTS > bruns wrote in advancedqueryparsertest.cpp:264 > Adds no information, just use QString() here (and twice below) This test fails. "no optimization" serves as a flag, that it's expected to fail and as mes

D11907: advancedqueryparsertest: Add more tests

michaelh updated this revision to Diff 31512. michaelh added a comment. - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31428&id=31512 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL https://phabri

D11907: advancedqueryparsertest: Add more tests

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11907: advancedqueryparsertest: Add more tests

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > advancedqueryparsertest.cpp:229 > +QTest::addColumn("failmessage"); > +const QString nofail; > +QString searchInput; remove > advancedqueryparsertest.cpp:231

D11907: advancedqueryparsertest: Add more tests

michaelh retitled this revision from "advancedqueryparsertest: Add more test" to "advancedqueryparsertest: Add more tests". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngra