D11907: advancedqueryparsertest: Add more test

michaelh marked 5 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

michaelh updated this revision to Diff 31428. michaelh added a comment. - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31390&id=31428 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL https://phabri

D11907: advancedqueryparsertest: Add more test

bruns added a dependent revision: D11826: Simplify Term operator&& and ||. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

bruns added inline comments. INLINE COMMENTS > advancedqueryparsertest.cpp:235 > +<< Term{Term::And, QList{ > +Term{QStringLiteral(""), QStringLiteral("a"), Term::Contains}, > +Term{QStringLiteral(""), QStringLiteral("b"), Term::Contains}, `Term{QString(), QString

D11907: advancedqueryparsertest: Add more test

bruns added inline comments. INLINE COMMENTS > michaelh wrote in advancedqueryparsertest.cpp:255 > What about this one? Drop it? I think it should stay as it exercises the stack in the query parser Pseudocode: s[0] = a, AND s[1] = b, AND t = construct (c AND d) t = Term( s[1].term, t,

D11907: advancedqueryparsertest: Add more test

michaelh added inline comments. INLINE COMMENTS > advancedqueryparsertest.cpp:255 > +; > +searchInput = QStringLiteral("(a AND (b AND (c AND d)))"); > +QTest::newRow(qPrintable(searchInput)) What about this one? Drop it? REPOSITORY R293 Baloo REVISION DETAIL https://phabric

D11907: advancedqueryparsertest: Add more test

michaelh updated this revision to Diff 31390. michaelh added a comment. - Remove duplicated data again REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31381&id=31390 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL https://p

D11907: advancedqueryparsertest: Add more test

michaelh added a comment. With this D11826 makes a difference. In terms of comprehension I'm also almost there. `testNestedParentheses` still has some value as it tests nested parentheses more extensively than the one already there. Unless you have

D11907: advancedqueryparsertest: Add more test

michaelh updated this revision to Diff 31381. michaelh added a comment. - Add (a AND b) AND (c OR d) can be merged as (a AND b AND (c OR D) REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31375&id=31381 BRANCH advancedqueryparsertest (branched from

D11907: advancedqueryparsertest: Add more test

michaelh updated this revision to Diff 31375. michaelh added a comment. - Remove duplicated data REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31373&id=31375 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL https://phabric

D11907: advancedqueryparsertest: Add more test

michaelh retitled this revision from "advancedqueryparsertest: Add optimization test" to "advancedqueryparsertest: Add more test". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spooru