D11882: extractortest: Use built executable instead of installed

michaelh added a comment. In D11882#239638 , @alexeymin wrote: > Code looks fine, but I did not test if it actually works. ;) It's a little hard to see the effect of this, because the installed extractor and the freshly built have to dif

D11882: extractortest: Use built executable instead of installed

michaelh marked 3 inline comments as done. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11882: extractortest: Use built executable instead of installed

michaelh updated this revision to Diff 31289. michaelh added a comment. - Move excess space to line 58 REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11882?vs=31267&id=31289 BRANCH testexe (branched from master) REVISION DETAIL https://phabricat

D11882: extractortest: Use built executable instead of installed

alexeymin added a comment. Code looks fine, but I did not test if it actually works. ;) INLINE COMMENTS > filemetadatawidgettest.cpp:58 > +const auto extractorPath = QDir( > QStringLiteral("%1/baloo_filemetadata_temp_extractor").arg(QFINDTESTDATA("../src"))).absolutePath(); > + > QCO

D11882: extractortest: Use built executable instead of installed

michaelh added a dependent revision: D11913: Change property selection to opt-in. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11882: extractortest: Use built executable instead of installed

michaelh updated this revision to Diff 31267. michaelh added a comment. - Use list separator REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11882?vs=31265&id=31267 BRANCH testexe (branched from master) REVISION DETAIL https://phabricator.kde.org

D11882: extractortest: Use built executable instead of installed

michaelh added inline comments. INLINE COMMENTS > alexeymin wrote in filemetadatawidgettest.cpp:60 > Should probably use `QDir::listSeparator()` instead of this `#ifdef` logic Great! Thanks. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: michaelh, elv

D11882: extractortest: Use built executable instead of installed

alexeymin added inline comments. INLINE COMMENTS > filemetadatawidgettest.cpp:60 > +qputenv("PATH", qPrintable(QStringLiteral("%1;%2").arg(np).arg(op))); > +#endif > +const auto extractorPath = QDir( > QStringLiteral("%1/baloo_filemetadata_temp_extractor").arg(QFINDTESTDATA("../src")

D11882: extractortest: Use built executable instead of installed

michaelh updated this revision to Diff 31265. michaelh added a comment. - Add our extractor to PATH REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11882?vs=31145&id=31265 BRANCH testexe (branched from master) REVISION DETAIL https://phabricator.

D11882: extractortest: Use built executable instead of installed

michaelh created this revision. michaelh added reviewers: elvisangelaccio, Baloo, Frameworks. Restricted Application added a project: Baloo. michaelh requested review of this revision. REPOSITORY R824 Baloo Widgets BRANCH testexe (branched from master) REVISION DETAIL https://phabricator.k