D11851: Add syntax highlighting for Logcat

2018-04-15 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:9feb73b7222c: Add syntax highlighting for Logcat (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11851?vs=31

D11851: Add syntax highlighting for Logcat

2018-04-10 Thread Nibaldo González
nibags added a comment. Everything is ready. But my account is not developer and I do not have permission to push it to the repository. REPOSITORY R216 Syntax Highlighting BRANCH add-logcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D11851 To: nibags, #framewo

D11851: Add syntax highlighting for Logcat

2018-04-09 Thread Nibaldo González
nibags updated this revision to Diff 31767. nibags added a comment. - I added two lines to the test file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11851?vs=31729&id=31767 BRANCH add-logcat (branched from master) REVISION DETAIL https:

D11851: Add syntax highlighting for Logcat

2018-04-09 Thread Nibaldo González
nibags updated this revision to Diff 31729. nibags added a comment. - New test file. I also merged some RegExpr rules. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11851?vs=31075&id=31729 BRANCH add-logcat (branched from master) REVIS

D11851: Add syntax highlighting for Logcat

2018-04-08 Thread Nibaldo González
nibags added a comment. It's a poem by Nicanor Parra. If you want I can change the test for a real log... REPOSITORY R216 Syntax Highlighting BRANCH add-logcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D11851 To: nibags, #framework_syntax_highlighting, cullma

D11851: Add syntax highlighting for Logcat

2018-04-08 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think it looks ok, no hard-coded colors, it seems to pass the basic static checks and we have a testcase. I would more like to have a test case in plain english, but the text just s

D11851: Add syntax highlighting for Logcat

2018-03-31 Thread Nibaldo González
nibags edited the summary of this revision. nibags added a reviewer: Framework: Syntax Highlighting. nibags added a project: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11851 To: nibags, #framework_syntax_highlighting Cc: #

D11851: Add syntax highlighting for Logcat

2018-03-31 Thread Nibaldo González
nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. nibags requested review of this revision. REVISION SUMMARY Add the XML file for Android Logcat. This syntax highlighting file supports all log formats, in