This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R293:890c0ff46ec9: Do not retrieve mtime from database
repeatedly when sorting (authored by bruns).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabr
michaelh accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
searchstore_speedup_1
REVISION DETAIL
https://phabricator.kde.org/D11827
To: bruns, #baloo, michaelh
Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, alexey
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> michaelh wrote in searchstore.cpp:122
> Please use braces.
Hunk omitted, as unrelated
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11827
To: bruns, #baloo, michaelh
Cc: michaelh, #
bruns updated this revision to Diff 31162.
bruns added a comment.
Drop unrelated commit squashed by arc ...
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11827?vs=31007&id=31162
BRANCH
searchstore_speedup_1
REVISION DETAIL
https://phabricator.kde.org/D
michaelh requested changes to this revision.
michaelh added a comment.
This revision now requires changes to proceed.
Specially with `--limit` this is a considerable speed gain. Thank you.
INLINE COMMENTS
> searchstore.cpp:122
>
> -while (it->next() && (limit < 0 || i < end)) {
> +
bruns updated this revision to Diff 31007.
bruns added a comment.
- Do not retrieve document ID for skipped result entries
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11827?vs=31006&id=31007
BRANCH
searchstore_speedup_2
REVISION DETAIL
https://phabri
bruns edited the summary of this revision.
bruns edited the test plan for this revision.
bruns added a reviewer: Baloo.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11827
To: bruns, #baloo
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin
bruns created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.
REVISION SUMMARY
For larger result sets, querying the mtime (once for lhs and rhs each)
on each sorting step co
