D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

2018-09-01 Thread Volker Krause
vkrause added a comment. In D11776#318339 , @Martchus wrote: > @vkrause Thanks for confirming. So it is not a local issue. Could you find a workaround (beside reverting these changes)? I edit the file `stl` in the build dir to strip out t

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

2018-08-31 Thread Marius Kittler
Martchus added a comment. @vkrause Thanks for confirming this. So it is not a local issue. Could you find a workaround (beside reverting these changes)? As I already mentioned, I'm not so familiar. However, for me the way CMake populates `CMAKE_CXX_STANDARD_LIBRARIES` doesn't look comple

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

2018-08-31 Thread Volker Krause
vkrause added a comment. It's the same issue I have here, but after our discussion at Akademy I assumed this to be local setup issue. Similar versions here, on Tumbleweed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D11776 To: apol, #frameworks, #buil

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

2018-08-31 Thread Marius Kittler
Martchus added a comment. @apol I'm not that familiar with Android, but I guess the variable `CMAKE_CXX_STANDARD_LIBRARIES` is not limited to contain only a single library (note the plural in the variable name). So I think we should handle that. BTW, I'm just testing with the `accelbubbl

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

2018-08-31 Thread Aleix Pol Gonzalez
apol added a comment. @Martchus sounds like your CMAKE_CXX_STANDARD_LIBRARIES gets initialized wrong somehow, no? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D11776 To: apol, #frameworks, #build_system, vkrause Cc: kde-frameworks-devel, kde-buildsyste

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

2018-08-31 Thread Marius Kittler
Martchus added a comment. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. This change produces invalid JSON in my setup: "stdcpp-path":" "/opt/android-ndk/sources/cxx-stl/gnu-libstdc++/4.9/libs/arm64-v8a/libgnustl_shared.so" -nodefaultlibs -lgcc -lc -lm -ldl", So

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

2018-04-04 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R240:731ba7036eff: Make use of upstream CMake infrastructure to detect the compiler toolchain (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

2018-03-28 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Nice! Works fine in my setup too. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D11776 To: apol, #frameworks, #build_system, vkraus

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

2018-03-28 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, Build System. Restricted Application added projects: Frameworks, Build System. apol requested review of this revision. REVISION SUMMARY Instead of having ad-hoc code for gcc, let CMake do its thing. It has a lot of logic that we may