D11735: Make it possible to fully build the project when crosscompiling

2018-03-28 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R216:683fc509a1ad: Make it possible to fully build the project when crosscompiling (authored by apol). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11735?v

D11735: Make it possible to fully build the project when crosscompiling

2018-03-28 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 30791. apol added a comment. Use the variable instead of hardcoding a path REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11735?vs=30677&id=30791 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D11735: Make it possible to fully build the project when crosscompiling

2018-03-28 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D11735 To: apol, #frameworks, vkrause, dhaumann Cc: michaelh, ngraham

D11735: Make it possible to fully build the project when crosscompiling

2018-03-28 Thread Aleix Pol Gonzalez
apol added a comment. In D11735#235888 , @vkrause wrote: > Clever idea, and should be safe for existing cross-compilation setups like Yocto. The only thing that looks suspicious to me is the hardcoded "/opt/nativetooling/" path. Is that really n

D11735: Make it possible to fully build the project when crosscompiling

2018-03-28 Thread Volker Krause
vkrause added a comment. Clever idea, and should be safe for existing cross-compilation setups like Yocto. The only thing that looks suspicious to me is the hardcoded "/opt/nativetooling/" path. Is that really needed? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricat

D11735: Make it possible to fully build the project when crosscompiling

2018-03-26 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, vkrause, dhaumann. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY Use cmake ExternalProject to compile the native tool we need to successfully build this framework. Mak