D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a comment. In D11176#291740 , @bcooksley wrote: > This change has broken the build of all projects that make use of pmap resources on Windows, as the Python path at build time is not necessarily the path at install time (and i

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

bcooksley added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. This change has broken the build of all projects that make use of pmap resources on Windows, as the Python path at build time is not necessarily the path at install time (a

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a comment. In D11176#241716 , @dfaure wrote: > Reference: https://build.kde.org/view/Frameworks/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/24/testReport/(root)/TestSuite/ki18n_install/ but also reproducible locally.

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

dfaure added a comment. Reference: https://build.kde.org/view/Frameworks/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/24/testReport/(root)/TestSuite/ki18n_install/ but also reproducible locally. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11176 To: cgiboudeaux C

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

dfaure added a comment. This broke the unittest : c Internal cmake changing into directory: /d/kde/build/5/frameworks/ki18n/autotests/ki18n_install Error: cmake execution failed The C compiler identification is GNU 4.8.5 The CXX compiler identification is GNU 5.3.1 Check for wor

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a comment. In D11176#235843 , @sitter wrote: > @cgiboudeaux @dfaure [...] > This is gonna cause trouble major trouble for the next release. No, it's a very minor issue that's already fixed. REPOSITORY R249 KI

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

sitter added subscribers: dfaure, sitter. sitter added a comment. @cgiboudeaux @dfaure I am almost entirely certain this broke building of ki18n itself when *it* contains translations. Neon packs translations into git builds, so here's the failure: https://build.neon.kde.org/job/xenia

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R249:6c1db934e648: Don't call PythonInterp.cmake in KF5I18NMacros. (authored by cgiboudeaux). REPOSITORY R249 KI18n CHAN

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a comment. ping. Unless someone objects, I will push this change in a couple days. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11176 To: cgiboudeaux Cc: #build_system, #frameworks, michaelh, ngraham

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a comment. Disclaimer: I'm not really happy with this solution. The alternative is to call find_program(KI18N_PYTHON_EXECUTABLE) with a list of known names (python3.7 python3.6 python2.7 ...) and remove the find_package(PythonInterp) line. REPOSITORY R249 KI18n REVI

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux edited the test plan for this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11176 To: cgiboudeaux Cc: #build_system, #frameworks, michaelh

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a project: Build System. cgiboudeaux added a subscriber: Build System. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11176 To: cgiboudeaux Cc: #build_system, #frameworks, michaelh

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. cgiboudeaux requested review of this revision. REVISION SUMMARY Due to CMake caching the variables, anything depending on ki18n would be unable to call