This revision was automatically updated to reflect the committed changes.
Closed by commit R249:a02e99069e15: Create a constructor for
KLocalizedStringPrivate (authored by jtamate).
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11149?vs=28990&id=29029
REVISION
ilic accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D11149
To: jtamate, #frameworks, ilic
Cc: ilic, michaelh
jtamate updated this revision to Diff 28990.
jtamate added a comment.
With spaces after : and ,
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11149?vs=28988&id=28990
REVISION DETAIL
https://phabricator.kde.org/D11149
AFFECTED FILES
src/klocalizedstring
ilic added inline comments.
INLINE COMMENTS
> klocalizedstring.cpp:202-204
> + :format()
> + ,numberSet(false)
> + ,markupAware(false)
Should have space after colon/comma?
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D11149
To: jtamate, #frameworks
C
jtamate created this revision.
jtamate added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.
REVISION SUMMARY
The constructor avoids the following asan runtime errors
kdesrc/frameworks/ki18n/src/klocalizedstring.cpp:179:7:
