D10829: Use DocumentId class

michaelh planned changes to this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10829 To: michaelh, adridg, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10829: Use DocumentId class

michaelh added a dependent revision: D10856: Make tests compile, except one. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10829 To: michaelh, adridg, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10829: Use DocumentId class

alexeymin added a comment. In D10829#213553 , @michaelh wrote: > That's great. Any clues to solve this? > > [ 35%] Building CXX object src/file/extractor/autotests/CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o > [ 35%] Linking CXX e

D10829: Use DocumentId class

michaelh added a comment. That's great. Any clues to solve this? [ 35%] Building CXX object src/file/extractor/autotests/CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o [ 35%] Linking CXX executable ../../../../bin/extractorIOTest CMakeFiles/extractorIOTest.dir/__/iohandler.cp

D10829: Use DocumentId class

michaelh updated this revision to Diff 28013. michaelh added a comment. - idutils: Use DocumentId constructor - DocumentId: Add 'QDebug operator<<' REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10829?vs=28008&id=28013 BRANCH use-class (branched from fle

D10829: Use DocumentId class

michaelh added a comment. @alexeymin: Could you use inline comments, please. That would help me a lot. And: thank you for your comments. It is really nice to have someone commenting without me poking first. ;-) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10829 To

D10829: Use DocumentId class

alexeymin added a comment. To solve this warning you need to fix DocumentId class, add operator<<() for QDebug. In D10826 add: `QDebug operator<<(QDebug stream, const Baloo::DocumentId &docId);` outside of baloo namespace, don't forget to `#include

D10829: Use DocumentId class

michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10829 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10829: Use DocumentId class

michaelh added a dependency: D10826: Introduce DocumentId class. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10829 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10829: Use DocumentId class

michaelh created this revision. michaelh added reviewers: adridg, Baloo, Frameworks. michaelh added a project: Baloo. Restricted Application added a project: Frameworks. michaelh requested review of this revision. TEST PLAN library compiles test compile produces linker error REPOSITORY R293