This revision was automatically updated to reflect the committed changes.
Closed by commit R246:8e51cbc03f72: Remove deprecated cmake code (authored by
vonreth).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10739?vs=27773&id=30563
REVISION DETAIL
https://p
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10739
To: vonreth, kfunk, dfaure, vkrause, mlaurent
Cc: apol, #frameworks, michaelh, ngraham
vonreth added inline comments.
INLINE COMMENTS
> apol wrote in CMakeLists.txt:20
> Then this also needs to go? Or just set it if the variable is defined?
That's how I understood the code, to allow to define a prebuild exe
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D
apol added inline comments.
INLINE COMMENTS
> CMakeLists.txt:20
> add_executable(KF5::parsetrigrams IMPORTED GLOBAL)
> set_target_properties(KF5::parsetrigrams PROPERTIES IMPORTED_LOCATION
> ${PARSETRIGRAMS_EXECUTABLE})
> else()
Then this also needs to go? Or just set it if the varia
vonreth added reviewers: kfunk, dfaure, vkrause, mlaurent.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D10739
To: vonreth, kfunk, dfaure, vkrause, mlaurent
Cc: #frameworks, michaelh
vonreth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vonreth requested review of this revision.
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10739
AFFECTED FILES
dat
