D10662: indexerconfig: Describe some functions

This revision was automatically updated to reflect the committed changes. Closed by commit R293:70162de9741e: indexerconfig: Describe some functions (authored by michaelh). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10662?vs=27764&id=27791#toc REPOSITORY R293 Baloo CHANGES SINCE L

D10662: indexerconfig: Describe some functions

michaelh updated this revision to Diff 27764. michaelh added a comment. - Revert includes coding style REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10662?vs=27762&id=27764 BRANCH publicdescriptions (branched from master) REVISION DETAIL https://phabri

D10662: indexerconfig: Describe some functions

lbeltrame added inline comments. INLINE COMMENTS > fileindexerconfig.h:25 > +#include > +#include > I just noticed this. Can you do the #include changes as part of a separate commit? REPOSITORY R293 Baloo BRANCH publicdescriptions (branched from master) REVISION DETAIL https://phab

D10662: indexerconfig: Describe some functions

michaelh marked an inline comment as done. REPOSITORY R293 Baloo BRANCH publicdescriptions (branched from master) REVISION DETAIL https://phabricator.kde.org/D10662 To: michaelh, #baloo, lbeltrame Cc: lbeltrame, adridg, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeym

D10662: indexerconfig: Describe some functions

michaelh marked an inline comment as done. michaelh added inline comments. INLINE COMMENTS > lbeltrame wrote in fileindexerconfig.h:50 > I'd put "index and analyze". Seems nitpicky, but reflects what Baloo does > (index first, extraction later). To be really nitpicky it is index > analyze > ind

D10662: indexerconfig: Describe some functions

michaelh updated this revision to Diff 27762. michaelh marked an inline comment as done. michaelh added a comment. - Refine descriptions more - Apply coding style to includes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10662?vs=27673&id=27762 BRANCH p

D10662: indexerconfig: Describe some functions

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Looks OK to me with some changes (for readability). INLINE COMMENTS > fileindexerconfig.h:50 > /** > - * The folders to search for files to analyze. Cached and cleaned up. >

D10662: indexerconfig: Describe some functions

michaelh added a project: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10662 To: michaelh, #baloo Cc: adridg, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10662: indexerconfig: Describe some functions

michaelh marked 3 inline comments as done. michaelh added inline comments. INLINE COMMENTS > adridg wrote in indexerconfig.h:45 > This makes it unclear if the entire path is used, (e.g. `\p path`) or whether > some special part of the path (the dir) is used for matching. It *might* be > nice to

D10662: indexerconfig: Describe some functions

michaelh updated this revision to Diff 27673. michaelh added a comment. - indexerconfig: Rephrase description REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10662?vs=27662&id=27673 BRANCH publicdescriptions (branched from master) REVISION DETAIL https:/

D10662: indexerconfig: Describe some functions

michaelh added inline comments. INLINE COMMENTS > adridg wrote in indexerconfig.h:53 > What does "cached and cleaned up" mean here? (Same applies below) Here, nothing :-) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10662 To: michaelh, #baloo Cc: adridg, #frameworks,

D10662: indexerconfig: Describe some functions

michaelh updated this revision to Diff 27662. michaelh added a comment. - fileindexerconfig: Make descriptions consistent - indexerconfig: Make descriptions consistent REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10662?vs=27552&id=27662 BRANCH publicde

D10662: indexerconfig: Describe some functions

adridg added inline comments. INLINE COMMENTS > indexerconfig.h:45 > + * match any of the exclude filters. Only the name of the > + * dir itself it checked. > + * This makes it unclear if the entire path is used, (e.g. `\p path`) or whether some special part of the path (the dir) is

D10662: indexerconfig: Describe some functions

michaelh added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10662 To: michaelh, #baloo Cc: #frameworks, michaelh

D10662: indexerconfig: Describe some functions

michaelh created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REPOSITORY R293 Baloo BRANCH publicdescriptions (branched from master) REVISION DETAIL https://phabricator.