This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ec296c0ff511: Convert from old connect syntax to new one
(authored by jtamate).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10537?vs=28102&id=28136
REVISION DETAIL
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10537
To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh
jtamate updated this revision to Diff 28102.
jtamate added a comment.
Fixed David comments.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10537?vs=27238&id=28102
REVISION DETAIL
https://phabricator.kde.org/D10537
AFFECTED FILES
src/core/listjob.cpp
src
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> listjob.cpp:140
> +QObject::connect(job, &ListJob::entries, q,
> +[this](KIO::Job *job,const KIO::UDSEntryList &lis
jtamate updated this revision to Diff 27238.
jtamate edited the test plan for this revision.
jtamate added a comment.
fixed broulik comment.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10537?vs=27235&id=27238
REVISION DETAIL
https://phabricator.kde.org/D1
broulik added inline comments.
INLINE COMMENTS
> listjob.cpp:140
> +QObject::connect(job, &ListJob::entries, q,
> +[this](KIO::Job* job,KIO::UDSEntryList list)
> +{gotEntries(job, list);} );
`const KIO::UDSEntryList &`
REPOSITO
jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.
REVISION SUMMARY
Starting plasmashell with callgrind I noticed a line:
QObject::connect: No such slot KIO::ListJob::slotTot
