D10433: Add QML support for Prison

This revision was automatically updated to reflect the committed changes. Closed by commit R280:6fb9f3f5b21f: Add QML support for Prison (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10433?vs=26950&id=27911 REVISION DETAIL https://pha

D10433: Add QML support for Prison

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D10433 To: vkrause, #frameworks, svuorela Cc: broulik, davidedmundson, michaelh

D10433: Add QML support for Prison

vkrause added a comment. The interface for outputting barcodes is currently QImage. The problem is that QtQuick cannot directly consume a QImage without custom glue code (image provider, custom item, etc), unlike e.g. a QLabel. Using an image provider would allow standard Image elements to c

D10433: Add QML support for Prison

svuorela added a comment. I am a bit unsure if this is the right approach. I can still be convinced both ways. one of the big differences from prison/qt4 to prison/qt5 was that it changed from being a barcode display library to a barcode generation library, removing all means of actuall

D10433: Add QML support for Prison

vkrause added a comment. ping? :) REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D10433 To: vkrause, #frameworks, svuorela Cc: broulik, davidedmundson, michaelh

D10433: Add QML support for Prison

vkrause updated this revision to Diff 26950. vkrause added a comment. Address review comments. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10433?vs=26907&id=26950 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10433 AFFECTED FILES .gi

D10433: Add QML support for Prison

vkrause added a comment. In D10433#204528 , @broulik wrote: > Cool! Would allow us to get rid of the custom barcode stuff in Plasma's clipboard plasmoid. > > Does barcode generation need to be in a separate thread? The Plasma codes does it,

D10433: Add QML support for Prison

broulik added a comment. Cool! Would allow us to get rid of the custom barcode stuff in Plasma's clipboard plasmoid. Does barcode generation need to be in a separate thread? The Plasma codes does it, not sure how big of a performance impact this has? INLINE COMMENTS > barcodequickitem.

D10433: Add QML support for Prison

vkrause updated this revision to Diff 26907. vkrause added a comment. Address review comments. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10433?vs=26896&id=26907 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10433 AFFECTED FILES .gi

D10433: Add QML support for Prison

vkrause added inline comments. INLINE COMMENTS > davidedmundson wrote in barcodequickitem.cpp:37 > Is createBarcode a heavy function? It sounds like it could be. > > If so I'd recommend using QQmlParserStatus so you don't generate it 4 times > on startup as each property gets set. Right, that'

D10433: Add QML support for Prison

davidedmundson added a comment. Cool in principle, few nitpicks. INLINE COMMENTS > barcodequickitem.cpp:37 > +BarcodeQuickItem::BarcodeQuickItem(QQuickItem *parent) > +: QQuickPaintedItem(parent) > +{ Is createBarcode a heavy function? It sounds like it could be. If so I'd recommend usi

D10433: Add QML support for Prison

vkrause created this revision. vkrause added reviewers: Frameworks, svuorela. Restricted Application added a project: Frameworks. vkrause requested review of this revision. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D10433 AFFECTED FILES .gitignore