This revision was automatically updated to reflect the committed changes.
Closed by commit R268:7d272782a55e: Don't assert if used incorrectly from
dbus (authored by graesslin).
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10081?vs=26098&id=28562
REVIS
romangg accepted this revision.
REPOSITORY
R268 KGlobalAccel
BRANCH
dont-assert-on-dbus-misusage
REVISION DETAIL
https://phabricator.kde.org/D10081
To: graesslin, #frameworks, apol, romangg
Cc: romangg, michaelh, kmorwinski
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R268 KGlobalAccel
BRANCH
dont-assert-on-dbus-misusage
REVISION DETAIL
https://phabricator.kde.org/D10081
To: graesslin, #frameworks, apol
Cc: romangg, michaelh
graesslin added a comment.
ping
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D10081
To: graesslin, #frameworks
Cc: romangg, michaelh
graesslin updated this revision to Diff 26098.
graesslin added a comment.
Remove the usless assert Roman found
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10081?vs=25895&id=26098
BRANCH
dont-assert-on-dbus-misusage
REVISION DETAIL
https://phab
romangg added inline comments.
INLINE COMMENTS
> component.cpp:251
> {
> Q_ASSERT(shortcut.context()->component() == this);
> // In production mode do nothing
Also always false.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D10081
To:
graesslin created this revision.
graesslin added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
graesslin requested review of this revision.
REVISION SUMMARY
The component dbus interface allowed to remote kill the wayland session
by sending an incorrect request to
