D10072: Add APKBUILD to be highlighted as a Bash file

2018-02-12 Thread Bhushan Shah
bshah added a comment. In D10072#204816 , @ltoscano wrote: > I suggest to push a revert and push it again with the right metadata. done. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: Pure

D10072: Add APKBUILD to be highlighted as a Bash file

2018-02-12 Thread Luigi Toscano
ltoscano added a comment. I suggest to push a revert and push it again with the right metadata. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: ltoscano, dhaumann, bshah, vkrause, bcooksley, #frameworks, michaelh

D10072: Add APKBUILD to be highlighted as a Bash file

2018-02-12 Thread Bhushan Shah
bshah added a comment. Uhm sorry, arc screwed up author metadata :-( but submitted patch anyway. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks, michaelh

D10072: Add APKBUILD to be highlighted as a Bash file

2018-02-12 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R216:7bafdc592040: Add APKBUILD to be highlighted as a Bash file (authored by bshah). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10072?vs=25985&id=26985

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-26 Thread Bart Ribbers
PureTryOut updated this revision to Diff 25985. PureTryOut added a comment. Updated the version from 6 to 7 REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10072?vs=25871&id=25985 REVISION DETAIL https://phabricator.kde.org/D10072 AFFECTED FI

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-26 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-26 Thread Dominik Haumann
dhaumann added a comment. The version needs to be increased from 6 to 7. Besides this, the patch looks good. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-25 Thread Bhushan Shah
bshah added subscribers: vkrause, bshah. bshah added a reviewer: vkrause. bshah added a comment. Adding @vkrause as reviewer who is listed as maintainer in metainfo.yaml REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: bsh

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-25 Thread Bart Ribbers
PureTryOut added a comment. @bcooksley well I'd love to add a reviewer, but I'm not sure who? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut Cc: bcooksley, #frameworks

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-24 Thread Ben Cooksley
bcooksley added a comment. In order for someone to approve this revision, add a reviewer, or subscribe it is necessary for them to have permission to edit the review. I have therefore unlocked the edit policy on this review. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://p

D10072: Add APKBUILD to be highlighted as a Bash file

2018-01-24 Thread Bart Ribbers
PureTryOut created this revision. PureTryOut created this object with edit policy "Only User: PureTryOut (Bart Ribbers)". Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. PureTryOut requested review of this revision. REVISION SUMMARY APK