D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann closed this revision. dhaumann added a comment. Close as it should work now. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann added a comment. This is fixed, see commit https://phabricator.kde.org/R39:1a38adebb64e6e7d5acb756f68166d56d8ba0b72 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, de

D10054: Fix: View jumps when Scroll past end of document is enabled

cullmann added a comment. No idea ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann added a comment. Question is: what happens in the vi test? Did we really introduce a regression or is the test wrong? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham,

D10054: Fix: View jumps when Scroll past end of document is enabled

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Then lets reopen it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew, ngraham,

D10054: Fix: View jumps when Scroll past end of document is enabled

rikmills added a comment. This change appears to cause ktexteditor to fail it's vimode_completion autotests. From KDE CI: https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/35/testReport/junit/(root)/TestSuite/vimode_completion/ Ubuntu autotests: F5707888: tes

D10054: Fix: View jumps when Scroll past end of document is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2bed94b6d463: Fix: View jumps when Scroll past end of document is enabled (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10054?vs=25837&id

D10054: Fix: View jumps when Scroll past end of document is enabled

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yeah, logic did seem to be flawed. To only look at the line makes sense. +1 for unit test ;=) (aka Fleißsternchen) REPOSITORY R39 KTextEditor BRANCH FixScrollPastEnd (branc

D10054: Fix: View jumps when Scroll past end of document is enabled

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann updated this revision to Diff 25837. dhaumann added a comment. - Add unit test for scroll past end of document REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10054?vs=25830&id=25837 BRANCH FixScrollPastEnd (branched from master) REVISION DET

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D10054: Fix: View jumps when Scroll past end of document is enabled

dhaumann created this revision. dhaumann added a reviewer: cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. dhaumann requested review of this revision. REVISION SUMMARY This patch fixes a corner case for the following setup