D10045: Don't assert on empty names

2018-01-30 Thread Milian Wolff
mwolff added inline comments. INLINE COMMENTS > remoteimpl.cpp:56 > > -const QStringList filenames = dir.entryList(QDir::Files | > QDir::Readable); > +const QStringList filenames = > dir.entryList({QStringLiteral("*.desktop")}, > +

D10045: Don't assert on empty names

2018-01-30 Thread Milian Wolff
mwolff updated this revision to Diff 26203. mwolff added a comment. filter out empty entries from remote:/ KIO slave REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10045?vs=25808&id=26203 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10045 A

D10045: Don't assert on empty names

2018-01-30 Thread Milian Wolff
mwolff added a comment. OK, that's not enough. It seems like the file can sometimes be read while it's still empty: 7.098 debug: RemoteImpl::createEntry[/home/milian/projects/kf5/src/frameworks/kio/src/ioslaves/remote/remoteimpl.cpp:188]: UDS_NAME "" from "/home/milian/.local/share/re

D10045: Don't assert on empty names

2018-01-30 Thread Milian Wolff
mwolff added a comment. 41.919 warning: KConfigIniBackend::parseConfig[/home/milian/projects/kf5/src/frameworks/kconfig/src/core/kconfigini.cpp:253]: "KConfigIni: In file /home/milian/.local/share/remoteview/yxcvyxcv.desktop.lock, line 1: " Invalid entry (missing '=') 41.919 warning:

D10045: Don't assert on empty names

2018-01-29 Thread David Faure
dfaure added a comment. See https://phabricator.kde.org/D10172 for the fix for the first usability issue. However I can't reproduce the assert... Can you add this to your kio_remote to find out more? There must be one strange .desktop file around somewhere. diff --git a/src/ios

D10045: Don't assert on empty names

2018-01-24 Thread Milian Wolff
mwolff added a comment. In https://phabricator.kde.org/D10045#195097, @dfaure wrote: > Good point, done. I did the following: - in Dolphin, go to remote:/ - add network folder - allow execution of this script (separate usability issue) - webdav, then fill out the form fo

D10045: Don't assert on empty names

2018-01-23 Thread David Faure
dfaure added a comment. Good point, done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10045 To: mwolff, dfaure Cc: dhaumann, #frameworks

D10045: Don't assert on empty names

2018-01-23 Thread Dominik Haumann
dhaumann added a comment. @dfaure It seems to me there is some know-how in your head that you should add as comment to the ASSERT then ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10045 To: mwolff, dfaure Cc: dhaumann, #frameworks

D10045: Don't assert on empty names

2018-01-23 Thread David Faure
dfaure added a comment. That assert is there to catch a horrible bug in the kioslave. UDS_NAME is NOT supposed to be empty, ever. Which kioslave was this about? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10045 To: mwolff, dfaure Cc: #frameworks

D10045: Don't assert on empty names

2018-01-23 Thread Milian Wolff
mwolff created this revision. mwolff added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY This removes an assertion I just hit. Note how the code below che