Re: API review: FavIconManager vs FavIconHostRequestJob

2016-01-31 Thread Kevin Ottens
Hello, On Sunday, 31 January 2016 10:40:12 CET David Faure wrote: > On Thursday 28 January 2016 09:35:53 laurent Montel wrote: > > Yep some time I forgot it in kmail when I used manual call to start. > > So if you want to use it make it automatic it's better. > > I agree, but then I wonder why KJ

Re: API review: FavIconManager vs FavIconHostRequestJob

2016-01-31 Thread Kevin Ottens
Hello, Here comes my purely API focused comments. I'll snip anything else (even comments). If I missed something important due to this approach, feel free to point it out. On Thursday, 28 January 2016 01:33:32 CET David Faure wrote: > namespace KIO { > > class KIOGUI_EXPORT FavIconsManager : p

Re: API review: FavIconManager vs FavIconHostRequestJob

2016-01-31 Thread David Faure
On Sunday 31 January 2016 11:29:31 laurent Montel wrote: > Le dimanche 31 janvier 2016, 10:40:12 CET David Faure a écrit : > > On Thursday 28 January 2016 09:35:53 laurent Montel wrote: > > > +ecm_qt_declare_logging_category(kiogui_SRCS HEADER favicons_debug.h > > > IDENTIFIER FAVICONS_LOG CATEGORY

Re: API review: FavIconManager vs FavIconHostRequestJob

2016-01-31 Thread laurent Montel
Le dimanche 31 janvier 2016, 10:40:12 CET David Faure a écrit : > On Thursday 28 January 2016 09:35:53 laurent Montel wrote: > > +ecm_qt_declare_logging_category(kiogui_SRCS HEADER favicons_debug.h > > IDENTIFIER FAVICONS_LOG CATEGORY_NAME kde.kio.favicons) > > In this directory we will use just fa

Re: API review: FavIconManager vs FavIconHostRequestJob

2016-01-31 Thread David Faure
On Thursday 28 January 2016 09:35:53 laurent Montel wrote: > +ecm_qt_declare_logging_category(kiogui_SRCS HEADER favicons_debug.h > IDENTIFIER FAVICONS_LOG CATEGORY_NAME kde.kio.favicons) > In this directory we will use just favicon ? > Perhaps a more generic log name no ? Well, one debug area pe

Re: API review: FavIconManager vs FavIconHostRequestJob

2016-01-28 Thread laurent Montel
Hi I like the idea to move away from dbus. It's better for sure. Le jeudi 28 janvier 2016, 01:33:32 CET David Faure a écrit : > I'm working on a replacement for the favicons kded module (which lives in > libkonq), which will be a class in kio instead (proper C++ API certainly > beats just a DBus

API review: FavIconManager vs FavIconHostRequestJob

2016-01-27 Thread David Faure
I'm working on a replacement for the favicons kded module (which lives in libkonq), which will be a class in kio instead (proper C++ API certainly beats just a DBus interface as public API). I started from the DBus API of the kded module, cleaned up a number of things (in particular the awful "(