Aleix Pol wrote:
> I pushed a couple of new commits that remove the usage of macro_bool_to_01
> and the HAVE_QSSLSOCKET thing.
>
I assume you have no intention of merging that branch? The top commit looks
fine at least.
Please cherry-pick it to frameworks, and rebase and clean-up the rest of
On Wed, Oct 2, 2013 at 10:25 AM, Stephen Kelly wrote:
> Aurélien Gâteau wrote:
>
> > On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote:
> >> Hi,
> >> Since ReviewBoard is not working for me, I decided to send this review
> as
> >> an e-mail. I know it's less practical, but also I think it's imp
Aurélien Gâteau wrote:
> On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote:
>> Hi,
>> Since ReviewBoard is not working for me, I decided to send this review as
>> an e-mail. I know it's less practical, but also I think it's important to
>> get it done and I'd rather go reasonably fast with it be
On Wednesday 02 October 2013 10:14:12 Aurélien Gâteau wrote:
> On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote:
> > Hi,
> > Since ReviewBoard is not working for me, I decided to send this review as
> > an e-mail. I know it's less practical, but also I think it's important to
> > get it done and
On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote:
> Hi,
> Since ReviewBoard is not working for me, I decided to send this review as
> an e-mail. I know it's less practical, but also I think it's important to
> get it done and I'd rather go reasonably fast with it before we start
> getting too mu
Hi,
Since ReviewBoard is not working for me, I decided to send this review as
an e-mail. I know it's less practical, but also I think it's important to
get it done and I'd rather go reasonably fast with it before we start
getting too much conflicts.
This patch removes all find_package usages in th
