Re: [Kde-games-devel] Data migration issue

2015-03-26 Thread David Faure
On Monday 23 March 2015 00:25:14 Matthew Dawson wrote: > On March 22, 2015 06:19:46 PM David Faure wrote: > > But wait, this makes me realize another solution: kdelibs4configmigrator > > could load the framework integration plugin, which would take care of > > this, if installed. > > > > Patch att

Re: [Kde-games-devel] Data migration issue

2015-03-23 Thread Matthew Dawson
On March 24, 2015 12:59:26 AM Albert Astals Cid wrote: > El Dilluns, 23 de març de 2015, a les 00:25:14, Matthew Dawson va escriure: > > On March 22, 2015 06:19:46 PM David Faure wrote: > > > Any input? > > > > I'm generally fine with this implementation, it seems like it would fix > > the > > pro

Re: [Kde-games-devel] Data migration issue

2015-03-23 Thread Albert Astals Cid
El Dilluns, 23 de març de 2015, a les 00:25:14, Matthew Dawson va escriure: > On March 22, 2015 06:19:46 PM David Faure wrote: > > On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote: > > > Too late for KDE Applications 15.04 though now that i think, so maybe we > > > actually have to sugges

Re: [Kde-games-devel] Data migration issue

2015-03-22 Thread Matthew Dawson
On March 22, 2015 06:19:46 PM David Faure wrote: > On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote: > > Too late for KDE Applications 15.04 though now that i think, so maybe we > > actually have to suggest everybody using the migrator to add those extra > > lines? > > OK, that means: >

Re: [Kde-games-devel] Data migration issue

2015-03-22 Thread Albert Astals Cid
El Diumenge, 22 de març de 2015, a les 21:41:02, Albert Astals Cid va escriure: > El Diumenge, 22 de març de 2015, a les 18:19:46, David Faure va escriure: > > On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote: > > > Too late for KDE Applications 15.04 though now that i think, so maybe we

Re: [Kde-games-devel] Data migration issue

2015-03-22 Thread Albert Astals Cid
El Diumenge, 22 de març de 2015, a les 18:19:46, David Faure va escriure: > On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote: > > Too late for KDE Applications 15.04 though now that i think, so maybe we > > actually have to suggest everybody using the migrator to add those extra > > lines

Re: [Kde-games-devel] Data migration issue

2015-03-22 Thread David Faure
On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote: > Too late for KDE Applications 15.04 though now that i think, so maybe we > actually have to suggest everybody using the migrator to add those extra > lines? OK, that means: --- a/src/lib/util/kdelibs4configmigrator.h +++ b/src/lib/ut

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Albert Astals Cid
El Dissabte, 21 de març de 2015, a les 22:00:11, David Faure va escriure: > On Saturday 21 March 2015 19:18:53 laurent Montel wrote: > > Le Saturday 21 March 2015 17:05:06 Albert Astals Cid a écrit : > > > El Dissabte, 21 de març de 2015, a les 11:38:14, Matthew Dawson va > > escriure: > > > > On

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread David Faure
On Saturday 21 March 2015 19:18:53 laurent Montel wrote: > Le Saturday 21 March 2015 17:05:06 Albert Astals Cid a écrit : > > El Dissabte, 21 de març de 2015, a les 11:38:14, Matthew Dawson va escriure: > > > On March 21, 2015 04:29:25 PM Mathias Kraus wrote: > > > > Am Samstag, 21. März 2015, 11:

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread laurent Montel
Le Saturday 21 March 2015 17:05:06 Albert Astals Cid a écrit : > El Dissabte, 21 de març de 2015, a les 11:38:14, Matthew Dawson va escriure: > > On March 21, 2015 04:29:25 PM Mathias Kraus wrote: > > > Am Samstag, 21. März 2015, 11:06:02 schrieb Matthew Dawson: > > > > On March 21, 2015 04:00:11 P

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Albert Astals Cid
El Dissabte, 21 de març de 2015, a les 11:38:14, Matthew Dawson va escriure: > On March 21, 2015 04:29:25 PM Mathias Kraus wrote: > > Am Samstag, 21. März 2015, 11:06:02 schrieb Matthew Dawson: > > > On March 21, 2015 04:00:11 PM Mathias Kraus wrote: > > > > === > > > > KConfig config(QLatin1St

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Mathias Kraus
Am Samstag, 21. März 2015, 11:06:02 schrieb Matthew Dawson: > On March 21, 2015 04:00:11 PM Mathias Kraus wrote: > > === > > KConfig config(QLatin1String("kminesrc")); > > config.reparseConfiguration(); > > === > Sorry, my suggestion of using reparseConfiguration wasn't clear. I meant >

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Matthew Dawson
On March 21, 2015 04:29:25 PM Mathias Kraus wrote: > Am Samstag, 21. März 2015, 11:06:02 schrieb Matthew Dawson: > > On March 21, 2015 04:00:11 PM Mathias Kraus wrote: > > > === > > > KConfig config(QLatin1String("kminesrc")); > > > config.reparseConfiguration(); > > > === > > > > Sorry, m

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Mathias Kraus
Am Samstag, 21. März 2015, 14:06:03 schrieb David Faure: > On Saturday 21 March 2015 10:16:07 Mathias Kraus wrote: > > Am Samstag, 7. März 2015, 14:43:14 schrieb laurent Montel: > > > Le Saturday 07 March 2015 13:47:13 David Faure a écrit : > > > > > KdePlatformTheme::loadSetting > > > > > > > > T

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Mathias Kraus
Am Samstag, 7. März 2015, 14:43:14 schrieb laurent Montel: > Le Saturday 07 March 2015 13:47:13 David Faure a écrit : > > > KdePlatformTheme::loadSetting > > > > This code runs before the application name is set, but the fallback to > > argv[0] should still work. [This makes me realize that we sho

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Matthew Dawson
On March 21, 2015 04:00:11 PM Mathias Kraus wrote: > === > KConfig config(QLatin1String("kminesrc")); > config.reparseConfiguration(); > === Sorry, my suggestion of using reparseConfiguration wasn't clear. I meant using it against the global KSharedConfig, not a newly created KConfig. I

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread David Faure
On Saturday 21 March 2015 10:16:07 Mathias Kraus wrote: > Am Samstag, 7. März 2015, 14:43:14 schrieb laurent Montel: > > Le Saturday 07 March 2015 13:47:13 David Faure a écrit : > > > > KdePlatformTheme::loadSetting > > > > > > This code runs before the application name is set, but the fallback to

Re: [Kde-games-devel] Data migration issue

2015-03-07 Thread laurent Montel
Le Saturday 07 March 2015 13:47:13 David Faure a écrit : > > KdePlatformTheme::loadSetting > > This code runs before the application name is set, but the fallback to > argv[0] should still work. [This makes me realize that we should call > QCoreApplication::setApplicationName before creating the a

Re: [Kde-games-devel] Data migration issue

2015-03-07 Thread David Faure
> KdePlatformTheme::loadSetting This code runs before the application name is set, but the fallback to argv[0] should still work. [This makes me realize that we should call QCoreApplication::setApplicationName before creating the application instance, everywhere.]. > This function caches that

Re: [Kde-games-devel] Data migration issue

2015-03-04 Thread Mathias Kraus
Am Mittwoch, 4. März 2015, 10:04:11 schrieb Matthew Dawson: > On March 3, 2015 10:59:21 PM Mathias Kraus wrote: > > Hi, > > > > I noticed a problem with the data migration in the kdegames transition from > > kdelibs4 to kf5 and Albert Astals Cid suggested to ask frameworks devel for > > advice. >

Re: [Kde-games-devel] Data migration issue

2015-03-04 Thread Matthew Dawson
On March 3, 2015 10:59:21 PM Mathias Kraus wrote: > Hi, > > I noticed a problem with the data migration in the kdegames transition from > kdelibs4 to kf5 and Albert Astals Cid suggested to ask frameworks devel for > advice. > > In short, when the migration is run after the QCoreApplication is cre

Re: [Kde-games-devel] Data migration issue

2015-03-03 Thread Mathias Kraus
Hi, I noticed a problem with the data migration in the kdegames transition from kdelibs4 to kf5 and Albert Astals Cid suggested to ask frameworks devel for advice. In short, when the migration is run after the QCoreApplication is created, the migrated config is not used but the default values.