[Differential] [Commented On] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Eike Hein
hein added a comment. To expand on the updated patch (I wrote a new commit message, but Phab doesn't notice automatically): The TM appears to be the only user of TopPosedLeftAlignedPopup currently, and the new behavior is also in line with the "Popup positioned on the top" docstring for the

[Differential] [Commented On] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Eike Hein
hein added a comment. Although ... maybe one hack we could do is change the meaning of "TopPosedLeftAlignedPopup" to "bottom edge of menu at top of visualParent" instead of "0,0 of menu at top of visualParent". Marco? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://ph

[Differential] [Commented On] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Eike Hein
hein added a comment. I'm not convinced it's worth it. This patch allows writing the same sort of code we already have in ContainmentInterface for context menu placement. If we resort to doing it there then clearly we need it in other places as well. (And I wrote openRelative ...) I

[Differential] [Commented On] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Kai Uwe Broulik
broulik added a comment. We have this openRelateive thing with "bottom left posed" and what not, shouldn't it have a thing for "have the bottom left corner of the menu be at the top of the parent item"? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.o