Re: Re : KApiDox move from dedicated server to Jenkins

ently? In general I would say, just generate everything that has a Doxyfile ... but there might be good reasons against that regarding processing power? Cheers, Frederik

Re: Re : KApiDox move from dedicated server to Jenkins

ll look at soon. Those are secondary though, as in they have been there before. Cheers, Frederik

Re: KApiDox move from dedicated server to Jenkins

ystem, we would have to change that link again. Now with all the files in place (thanks for that :)) the links will just continue to work. Cheers, Frederik

KApiDox move from dedicated server to Jenkins

t. - The "Older versions" links are broken. Since those docs are not generated anymore, we need to figure out a way to have them available statically. If we do not see any bigger issues, I would like to go live with the new system in a week or two. Thanks for your help. CHeers, Frederik

Re: Noteworthy changes when porting to C++17

On 7/19/21 5:52 PM, David Faure wrote: On dimanche 18 juillet 2021 02:34:24 CEST Frederik Schwarzer wrote: So the question is: did you notice things that have been removed from the C++ standard since C++11 that were used in our applications? I found a list of things that were removed from

Re: Noteworthy changes when porting to C++17

Hi, Thanks for the links. I know about those papers but I do not think we should point KF6 application porters there because the vast majority of the stuff mentioned is very unlikely to affect them. For now I will go with some general remarks here. Cheers, Frederik On 7/18/21 10:22 AM

Noteworthy changes when porting to C++17

ee e.g. https://godbolt.org/z/6Y1eE3z4P for playing with it. But I digress ... So the question is: did you notice things that have been removed from the C++ standard since C++11 that were used in our applications? Cheers, Frederik

Re: Porting notes / deprecation docs

On 7/12/21 8:43 PM, Friedrich W. H. Kossebau wrote: Am Montag, 12. Juli 2021, 20:22:30 CEST schrieb Frederik Schwarzer: On 7/12/21 7:38 PM, Friedrich W. H. Kossebau wrote: Now what is meant by "clickable links to replacements" exactly? Any example for what you have in mind? (Ju

Re: Porting notes / deprecation docs

On 7/12/21 7:38 PM, Friedrich W. H. Kossebau wrote: Some hopefully helpful quick comments from couch: Am Montag, 12. Juli 2021, 19:14:17 CEST schrieb Frederik Schwarzer: - If not documented separately, should existing deprecation messages be improved? "no known users" mi

Re: Porting notes / deprecation docs

who get that message - Is it possible/desirable to keep the latest KF5 API docs as it is generated on api.k.o to have deprecation messages with clickable links to replacements? Opinions/additions? Cheers, Frederik On 7/11/21 2:24 PM, Frederik Schwarzer wrote: Hi, On 7/10/21 11:54 PM, Fried

Re: Porting notes / deprecation docs

Hi, On 7/10/21 11:54 PM, Friedrich W. H. Kossebau wrote: Am Samstag, 10. Juli 2021, 22:47:58 CEST schrieb Frederik Schwarzer: Hi, On 7/10/21 7:38 PM, Friedrich W. H. Kossebau wrote: Am Samstag, 10. Juli 2021, 18:00:13 CEST schrieb Frederik Schwarzer: as mentioned earlier Any pointers

Re: Porting notes / deprecation docs

Hi, On 7/10/21 7:38 PM, Friedrich W. H. Kossebau wrote: Am Samstag, 10. Juli 2021, 18:00:13 CEST schrieb Frederik Schwarzer: as mentioned earlier Any pointers? :) It was discussed in the weekly BBB meetings a few weeks ago. I would like to document classes/methods/etc that are going to

Re: Porting notes / deprecation docs

On 7/10/21 6:17 PM, Ahmad Samir wrote: On 10/07/2021 18:00, Frederik Schwarzer wrote: Hi, as mentioned earlier, I would like to document classes/methods/etc that are going to be deprecated during KF6 development. For that I scraped up all the deprecation macros from the frameworks and

Porting notes / deprecation docs

ch docs in markdown or restructured text for being better suited for a more modern location? Thanks! Cheers, Frederik

D24003: kwaylandScanner produce version enum per class

gladhorn marked an inline comment as done. gladhorn added inline comments. INLINE COMMENTS > zzag wrote in generator.cpp:431 > Is it correct thogugh? Can you provide some test input so it's easier to see > the problem? run kwaylandScanner on /usr/share/wayland-protocols/unstable/primary-select

D24004: Teach kwaylandscanner about PrimarySelection

gladhorn added subscribers: zzag, romangg, davidedmundson. gladhorn added a comment. @romangg and @davidedmundson any comments? I think @zzag prefers the class names without the V1. I'd like to progress on this step by step and the generator at least gives a good starting point. REPOSITORY

D24002: Sort files alphabetically in cmake list

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6c8f110f3a22: Sort files alphabetically in cmake list (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24002?vs=66278&id=66279 REVISION DETA

D24003: kwaylandScanner produce version enum per class

gladhorn added a comment. The unstable primary selection v1 protocol produces code that doesn't compile, after this change it does compile - since it expects the version enums for three classes, but only the first one is actually written into the file. REPOSITORY R127 KWayland REVISION DE

D24002: Sort files alphabetically in cmake list

gladhorn updated this revision to Diff 66278. gladhorn added a comment. Actually sort all files REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24002?vs=66254&id=66278 BRANCH arcpatch-D24002 REVISION DETAIL https://phabricator.kde.org/D24002 AFFECTED

D24004: Teach kwaylandscanner about PrimarySelection

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY This allows generating the skeleton classes for the primary selection protocol. REP

D24003: kwaylandScanner produce version enum per class

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY Otherwise it only creates the enum for the first class encountered. REPOSITORY R12

D24002: Sort files alphabetically in cmake list

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY Adding further files is confusing, since the list is almost alphabetical. REPOSITORY

D23915: Improve documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6388d550e3a2: Improve documentation (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23915?vs=66078&id=66150 REVISION DETAIL https://phabr

D23586: Improve code that detects useful elements in an Svg file

gladhorn added inline comments. INLINE COMMENTS > svg.cpp:103 > while (!reader.atEnd()) { > -if (reader.readNext() == QXmlStreamReader::StartElement && > +const auto t = reader.readNext(); > +if (t == QXmlStreamReader::StartElement) { Maybe use "eleme

D23915: Improve documentation

gladhorn updated this revision to Diff 66078. gladhorn retitled this revision from "Improve documentation Some of the documentation did not say what the purpose of the respective class was, but rather gave a tautology. For people new to the code base it helps to mention that DPMS is power manageme

D23917: Use const_iterator

This revision was automatically updated to reflect the committed changes. Closed by commit R127:28841048d555: Use const_iterator (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=66021&id=66027 REVISION DETAIL https://phabricat

D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS

gladhorn added inline comments. INLINE COMMENTS > romangg wrote in dpms.h:44 > Yea, maybe just write that this class is meant to create the DPMS object > below only. You already have the information you provided here there then. I agree. The first two lines are actually repetitions and they don

D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS

gladhorn updated this revision to Diff 66026. gladhorn retitled this revision from "Add some docstrings" to "Improve documentation Some of the documentation did not say what the purpose of the respective class was, but rather gave a tautology. For people new to the code base it helps to mention t

D23917: Use const_iterator

gladhorn updated this revision to Diff 66021. gladhorn edited the summary of this revision. gladhorn removed subscribers: broulik, zzag. gladhorn added a comment. Fixed two missing spots REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=65946&id=6602

D23917: Use const_iterator

gladhorn added a comment. Yes, for me always using constBegin/constEnd makes reading the code slightly easier. INLINE COMMENTS > zzag wrote in registry.cpp:879 > constEnd Thanks! > zzag wrote in output_interface.cpp:119 > constEnd Thanks! REPOSITORY R127 KWayland REVISION DETAIL htt

D23917: Use const_iterator

gladhorn updated this revision to Diff 65946. gladhorn added a comment. fixup REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=65945&id=65946 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23917 AFFECTED FILES src/client/plasmaw

D23917: Use const_iterator

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When trivial, replace iterators with the const versrion. REPOSITORY R127 KWayland

D23916: Remove capture of this in lambda

This revision was automatically updated to reflect the committed changes. Closed by commit R127:858d9255f722: Remove capture of this in lambda (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23916?vs=65943&id=65944 REVISION DETAIL ht

D23916: Remove capture of this in lambda

gladhorn updated this revision to Diff 65943. gladhorn added a comment. Remove more lambda this captures REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23916?vs=65942&id=65943 BRANCH arcpatch-D23916 REVISION DETAIL https://phabricator.kde.org/D23916

D23916: Remove capture of this in lambda

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When this is not used, there is no point in capturing it. REPOSITORY R127 KWayland

D23915: Add some docstrings

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When first reading the KWayland code, some explanations help getting around. REPOS

D14240: Improve API docs a bit

This revision was automatically updated to reflect the committed changes. Closed by commit R296:9dd578b12d40: Improve API docs a bit (authored by gladhorn). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14240?vs=38116&id=38145 REVISION DETAIL https://

D14240: Improve API docs a bit

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY Some typos and make some sentences easier to read

D14118: Improve "Remove this [widget]" text

gladhorn accepted this revision. gladhorn added a comment. This revision is now accepted and ready to land. I'd say make the casing consistent, otherwise it's a clear improvement in my opinion. INLINE COMMENTS > containment.cpp:127 > if (closeApplet) { > -closeApplet->setText(i1

D6877: Add Conan files

This revision was automatically updated to reflect the committed changes. Closed by commit R243:802d106c8e81: Add Conan files (authored by gladhorn). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17127&id=17153 REVISION DETAIL https://phabricator.k

D6877: Add Conan files

gladhorn updated this revision to Diff 17127. gladhorn marked an inline comment as done. gladhorn added a comment. fix url REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17126&id=17127 BRANCH master REVISION DETAIL https://phabricator.kde.org

D6877: Add Conan files

gladhorn marked 3 inline comments as done. gladhorn added inline comments. INLINE COMMENTS > apol wrote in conanfile.py:5 > Can we re-use the version from the `CMakeLists.txt`? The goal is to generate it. > apol wrote in conanfile.py:7 > Re-use from metainfo.yml? For now we consider this as a

D6877: Add Conan files

gladhorn updated this revision to Diff 17126. gladhorn added a comment. Updated according to comments REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17124&id=17126 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILE

D6877: Add Conan files

gladhorn updated this revision to Diff 17124. gladhorn added a comment. remove -git from the version REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17118&id=17124 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES

D6877: Add Conan files

gladhorn updated this revision to Diff 17118. gladhorn added a comment. Fix license REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17116&id=17118 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES conanfile.py

D6877: Add Conan files

gladhorn updated this revision to Diff 17116. gladhorn added a comment. Remove private test stuff REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6877?vs=17115&id=17116 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6877 AFFECTED FILES

D6877: Add Conan files

gladhorn created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Conan is a C++ package manager. This is an experiment to make KF5 frameworks available on Conan to make building KDE applications easier.

D6624: do not crash qaccessible by causing a resize in a resize event

gladhorn added a comment. Considering that the Qt bug will not be fixed in the next few days (I hope to get around to it, but it's involved), this makes sense. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D6624 To: sitter, gladhorn Cc: cfeck, anthonyfieroni

Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls

QWidget's file dialog when set to modal. Iirc this breaks for example the open dialogs in qt creator. - Frederik Gladhorn On March 12, 2015, 1:19 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

but needs cleanup and API review and a couple of features are not done on all platforms. - Frederik --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review75983 ---

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

ved from here I tend to agree to TTS or even better Text to Speech/Text-To-Speech. - Frederik --- This is an automatically generated e-mail. To reply, visit: https://git.reviewbo

Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

555/#comment52450> I have no idea how this is used, should it be i18n'ed? And Text to Speech - Frederik Gladhorn On Feb. 13, 2015, 3:11 a.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-m

Fwd: [Development] Qt Contributors' Summit 2014 in Berlin 10-11th June

great chance to influence many things in Qt directly with great discussions. Also a great start to getting deeper involved of course ;) See the forwarded mail for details. -- Best regards, Frederik Gladhorn Senior Software Engineer - Digia, Qt Visit us on: http://qt.digia.com --- Begin Me

Re: KSpeech

Torsdag 6. mars 2014 20.34.05 skrev Christoph Feck: > On Thursday 06 March 2014 17:13:19 Jeremy Whiting wrote: > > On Thu, Mar 6, 2014 at 6:43 AM, Frederik Gladhorn > > wrote: > > > Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting: > > >> 3. user configurabi

Re: KSpeech

> > Any thoughts on that? I would be pretty interested in helping with > qtspeech if it greatly simplifies or even deprecates jovie as it looks > like it could do possibly. I'd be more than happy to get contributions of course. I cannot promise much from my side, of course I

Re: KSpeech

voice/language configuration. On the up side, I implemented basic backends for win/mac/android/linux. Linux is using speech-dispatcher, but I was quite dissatisfied with spd's API. For example it lacks proper free functions for the structs it allocates - so one

Re: kf5 alpha 1 : attica?

On Thursday 6. February 2014 00.29.45 David Faure wrote: > Frederik wrote: > > From my point of view, please just go ahead and change it as you think is > > sensible. > > OK, thanks for the green lights, I went ahead: > > * Qt4 support for attica is now in the "

Re: kf5 alpha 1 : attica?

the qt4 support into a > separate branch first. > Which brings us to the next topic: who as maintainer should approve this. > > > Also, since no one stepped up to say if it should be in or out, I'd say it > > should be with no declared maintainer until someone claims it. >

Re: Review LibKdeAccessibilityClient

Søndag 7. oktober 2012 21.45.17 skrev Alexander Neundorf: > On Thursday 04 October 2012, Frederik Gladhorn wrote: > > Hi, > > > > so after we took the time to hack a bit more on the library in Randa, > > I would be happy about more comments. > > Why d

Re: Review LibKdeAccessibilityClient

h and works with Gnome and KDE apps (assuming you have qt- at-spi and libatspi2). Greetings Frederik On Thursday 23. August 2012 22.41.46 Kevin Ottens wrote: > Hello, > > On Thursday 16 August 2012 09:29:27 Frederik Gladhorn wrote: > > Feedback is much appreciated. > > If y

Re: Review LibKdeAccessibilityClient

By the way, the code is here: http://projects.kde.org/libkdeaccessibilityclient Cheers, Frederik Torsdag 16. august 2012 09.29.27 skrev Frederik Gladhorn: > Hi, > a few of us trying to improve accessibility of KDE worked on a little > library, LibKdeAccessibilityClient. > >

Review LibKdeAccessibilityClient

ary comes with a few auto-tests and one example application that lets one browse the running applications accessibility interfaces. Some of the improvements in that library were made by Amandeep as part of his summer of code project (with Sebastian mentoring). Feedback is much appreci