yuyichao accepted this revision.
yuyichao added a comment.
This revision is now accepted and ready to land.
Assuming the coordinate calculations are correct (which I can never get right
without seeing the result) this LGTM.
There was a previous issue on scaled display but I guess this sho
yuyichao accepted this revision.
yuyichao added a comment.
This revision is now accepted and ready to land.
Is this the new review platform?
LGTM. Hopefully I'm doing the right action here (phabricator always seem
to have way more buttons than I need..)
REVISION DETAIL
https://phab
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126624/#review91526
---
Ship it!
- Yichao Yu
On 一月 18, 2016, 11:48 a.m., René
> On 一月 11, 2016, 10:17 a.m., Yichao Yu wrote:
> > qt5/style/qtcurve_api.cpp, line 3211
> > <https://git.reviewboard.kde.org/r/126624/diff/1/?file=428407#file428407line3211>
> >
> > Should this be turned on only when KF5 is enabled?
>
> Aleix Pol G
tps://git.reviewboard.kde.org/r/126624/#comment62107>
Should this be turned on only when KF5 is enabled?
- Yichao Yu
On 一月 4, 2016, 11:28 a.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
the delay. I'm checking my email for the review requests but maybe
I'm not using the right filter or not subscribing to the right list.
- Yichao Yu
On 十二月 10, 2015, 12:12 p.m., René J.V. Bertin wrote:
>
> ---
> This
tps://git.reviewboard.kde.org/r/126304/#comment61891>
trailing white space
- Yichao Yu
On 十二月 10, 2015, 12:12 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
tps://git.reviewboard.kde.org/r/126304/#comment61892>
Also here
- Yichao Yu
On 十二月 10, 2015, 12:12 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboar
Anyway, yes, I understood perfectly well that X11 might not be available
> at runtime while it was when compiling, and that an application trying to do
> X11 calls will exit with an error when trying to connect to an inexisting X11
> server. (Or crash if X11 was actually uninstalle
Anyway, yes, I understood perfectly well that X11 might not be available
> at runtime while it was when compiling, and that an application trying to do
> X11 calls will exit with an error when trying to connect to an inexisting X11
> server. (Or crash if X11 was actually uninstalle
ssed in another review request
and it is not necessary to disable calls to X11 related functions (which might
be no-ops) on OSX anymore.
In any case, the issue related to this request should already be resolved now
and the status is also monitored on build.kde.org (and AFAIK both Qt4 and Qt5
versions build successfully now). I think this review request can be discar
11 matches
Mail list logo
