D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng added a comment. In D29668#669069 , @dfaure wrote: > What are the values of Context and Type? > > "Legacy" and "UI" ? > > I can't see anything in index.theme https://ftp.gnome.org/pub/GNOME/sources/adwaita-icon-theme/3.36/

D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng added a comment. You can try to install one from your distro to check the actual content. index.theme is generated during the "configure & make". REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29668 To: xuetianweng, #frameworks, dfaure, apol Cc: dav

D29789: Make text always align with font base line

xuetianweng added a comment. In D29789#672335 , @dhaumann wrote: > I like this patch. In fact, I observed over the past years again and again that sometimes, especially if chinese or similar letters are included, the baseline is wrong in Kate, l

D29789: Make text always align with font base line

xuetianweng added a comment. This is my another try as an alternative solution to D25339 . Actually this works surprisingly good IMHO, at least for CJK users for most cases. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29789

D29789: Make text always align with font base line

xuetianweng edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29789 To: xuetianweng, rjvbb, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann,

D29789: Make text always align with font base line

xuetianweng created this revision. xuetianweng added reviewers: rjvbb, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. xuetianweng requested review of this revision. REVISION SUMMARY When font uses other fallback font, th

D25339: update lineHeight if boundingRect indicates a larger value.

xuetianweng added a comment. Actually I was trying to use this approach in the patch because I was afraid that variable line height may need to estimate the whole document height to make scroll work correctly. But during this patching experience I realized that the ktexteditor first lin

D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng edited the test plan for this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29668 To: xuetianweng, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng added reviewers: dfaure, apol. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29668 To: xuetianweng, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng edited the test plan for this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29668 To: xuetianweng, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29668: Do not reject icon theme dir with invalid context/type.

xuetianweng created this revision. xuetianweng added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. xuetianweng requested review of this revision. REVISION SUMMARY For example, gnome's default theme adwaita has their own context type

D25339: update lineHeight if boundingRect indicates a larger value.

xuetianweng marked an inline comment as done. xuetianweng added a comment. In D25339#665432 , @rjvbb wrote: > With "we've ever seen" you do mean that lineheight only changes when a line that requires it scrolls into view? > > > Though line

D25339: update lineHeight if boundingRect indicates a larger value.

xuetianweng retitled this revision from "KateRenderer: Use representitive character in CJK to estimate the fontHeight." to "update lineHeight if boundingRect indicates a larger value.". xuetianweng edited the summary of this revision. xuetianweng edited the test plan for this revision. REPOSITOR

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. I'm not sure if this is the right way to do it or it might cause any glitch, but here we go. Upon line rendering, update the maximum height we've ever seen. Though line height won't shrink during the edit phase, it will back to the actual value upon save. R

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 82170. xuetianweng added a comment. Use actual line height instead of representitive character. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=80607&id=82170 BRANCH arcpatch-D25339 REVISION DETAIL

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. In D25339#663915 , @fakefred wrote: > I second the as-an-option proposal. Hey, why not automatically increase the line height when CJK characters are detected? So the thing is we need to maintain a such height

D29396: Suppress find_package_handle_standard_args package name mismatch warning.

This revision was automatically updated to reflect the committed changes. Closed by commit R240:8d181637a033: Suppress find_package_handle_standard_args package name mismatch warning. (authored by xuetianweng). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator

D29396: Suppress find_package_handle_standard_args package name mismatch warning.

xuetianweng created this revision. xuetianweng added reviewers: Frameworks, Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. xuetianweng requested review of this revision. REVISION SUMMARY cmake introduced a new find_

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80607. xuetianweng added a comment. Fix the blank text issue by alway setLineWidth. For QTextLine, the layout information is not filled until certain function is called. If dynamic wrap is not enabled, the line width is -1 so at the point we do

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80606. xuetianweng added a comment. Clean up the code a little bit and adding comments. Also fix a small bug if m_fontHeight has big difference with m_fontMetrics's height. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricat

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. In D25339#651701 , @cullmann wrote: > Hmm, after applying this patch, for me, no text is visible at all. > By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir). >

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. In D25339#651701 , @cullmann wrote: > Hmm, after applying this patch, for me, no text is visible at all. > By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir). >

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80444. xuetianweng added a comment. Fix the handling when layout formats has background. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=80438&id=80444 BRANCH arcpatch-D25339 REVISION DETAIL https:/

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. F8244684: Screenshot_20200417_222110.png Add a screenshot to demostrate the change. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor, cullmann, dhaumann Cc

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. In D25339#563937 , @cullmann wrote: > Actually, I could live with: > > 1. All lines are a bit higher, for me that makes reading even easier. But the rendering shall have no glitches. > 2. Some lines have differe

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80438. xuetianweng added a comment. handle the range with multiple lines. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=80433&id=80438 BRANCH arcpatch-D25339 REVISION DETAIL https://phabricator.kd

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80433. xuetianweng added a comment. Try to fill the gap if we increase the line height with representitive char. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=69848&id=80433 BRANCH arcpatch-D25339 R

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. Any idea about how konsole derive In D25339#563656 , @cullmann wrote: > The issue with this approach is, that you get "too high" lines for the case that none of this characters ever appear. > Beside that, unfo

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added reviewers: cullmann, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor, cullmann, dhaumann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sar

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. F7766842: Screenshot_20191116_092819.png Add screenshot to demonstrate the problem. And what I'd like to point is, for CJK users, it is uncommon for them to select a single font to cover all the characters, because

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 69848. xuetianweng added a comment. Add comment about the actual characters. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=69847&id=69848 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng created this revision. xuetianweng added a reviewer: KTextEditor. xuetianweng added projects: Kate, Frameworks. xuetianweng requested review of this revision. REVISION SUMMARY When a font has fallback, the fontHeight is broken can may cut the string in the middle in the line. Try t

D8800: Add a new function to measure the length by text.

This revision was automatically updated to reflect the committed changes. Closed by commit R244:6758d45cb596: Add a new function to measure the length by text. (authored by xuetianweng). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8800?vs=22287&id=22288

D8800: Add a new function to measure the length by text.

xuetianweng added a reviewer: Frameworks. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8800 To: xuetianweng, hein, apol, #frameworks Cc: #frameworks

D8800: Add a new function to measure the length by text.

xuetianweng created this revision. xuetianweng added reviewers: hein, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY CJK language contains more information per character. When people try to write code to cap the

D5805: include directory should contains all directory from pkg-config

xuetianweng abandoned this revision. xuetianweng added a comment. Just noticed that FindPkgConfig has import_module now.. Personally I just port my code to use that. Anyone who more familiar with test cmake script may take over this. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D8346: Remove blocking call in KStatusNotifierItem

xuetianweng added inline comments. INLINE COMMENTS > kstatusnotifieritem.cpp:882 > + > +QDBusPendingReply pendingReply = > statusNotifierWatcher->connection().call(call); > +auto watcher = new QDBusPendingCallWatcher(pendingReply); The template is not necessary here. Maybe auto

D8346: Remove blocking call in KStatusNotifierItem

xuetianweng added inline comments. INLINE COMMENTS > kstatusnotifieritem.cpp:879 > +} else { > +QDBusMessage call = > QDBusMessage::createMethodCall(statusNotifierWatcher->service(), > statusNotifierWatcher->path(), > QStringLiteral("org.freedesktop.DBus.Properties."), QStringLiter

D7491: Fix invalid id in viewitem.

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8d38df353422: Fix invalid id in viewitem. (authored by xuetianweng). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7491?vs=18618&id=19209 REVIS

D7491: Fix invalid id in viewitem.

xuetianweng added reviewers: Plasma, davidedmundson. xuetianweng added a comment. ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7491 To: xuetianweng, mart, #plasma, davidedmundson Cc: #frameworks

D7491: Fix invalid id in viewitem.

xuetianweng created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY It should be selected+hover instead of selected_hover. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D5631: Fix directory based search.

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5f6bd28119c6: Fix directory based search. (authored by xuetianweng). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5631?vs=13905&id=17950 REVISION DETAIL https://

D5805: include directory should contains all directory from pkg-config

xuetianweng added reviewers: apol, aacid. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5805 To: xuetianweng, apol, aacid Cc: #frameworks, #build_system

D5805: include directory should contains all directory from pkg-config

xuetianweng created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY For certain pkg-config file that depends on other pkg-config, e.g. pango depends on glib2, glib's include dir

D5631: Fix directory based search.

xuetianweng added a comment. I saw there's filesearchstoretest.cpp in autotests/integration, but CMakeLists.txt doesn't build it. I guess this test might not work yet. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5631 To: xuetianweng, #frameworks Cc: lbeltrame

D5631: Fix directory based search.

xuetianweng created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY canonicalPath() does not include the file name, but only the directory name. Should use canonicalFilePath() instead. TEST PLAN Manually test with baloosearch REPOSITORY R293 Baloo BRA

D5017: Fix ecm_generate_pkgconfig_file compatibility with new cmake

This revision was automatically updated to reflect the committed changes. Closed by commit R240:3980f36db018: Fix ecm_generate_pkgconfig_file compatibility with new cmake (authored by xuetianweng). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D501

D5017: Fix ecm_generate_pkgconfig_file compatibility with new cmake

xuetianweng created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY CMP0053 specifies that: - Expansion of ``@VAR@`` reference syntax defined by the ``configure_file()`` and ``string(C

D4769: Try to get the real port instead of always use DEFAULT_SFTP_PORT

This revision was automatically updated to reflect the committed changes. Closed by commit R320:40f1edc9a814: Try to get the real port instead of always use DEFAULT_SFTP_PORT (authored by xuetianweng). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4769?vs=11784&id=12138#toc REPOSITORY

D4769: Try to get the real port instead of always use DEFAULT_SFTP_PORT

xuetianweng marked 2 inline comments as done. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D4769 To: xuetianweng, #frameworks, apol, dfaure Cc: dfaure

Re: Review Request 127271: Disable session restore for kwalletd5

--- kwallet-pam back to work. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127271: Disable session restore for kwalletd5

it. Diffs (updated) - src/runtime/kwalletd/main.cpp 740e670 Diff: https://git.reviewboard.kde.org/r/127271/diff/ Testing --- kwallet-pam back to work. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

ewboard.kde.org/r/127166/diff/ Testing --- Compiles, startup notify works. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127271: Disable session restore for kwalletd5

it. Diffs (updated) - src/runtime/kwalletd/main.cpp 740e670 Diff: https://git.reviewboard.kde.org/r/127271/diff/ Testing --- kwallet-pam back to work. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 127271: Disable session restore for kwalletd5

> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian W

Re: Review Request 127271: Disable session restore for kwalletd5

> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian W

Re: Review Request 127271: Disable session restore for kwalletd5

t.reviewboard.kde.org/r/127271/#review93187 ------- On March 3, 2016, 8:34 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 127261: Fix dead lock when program use kauth exits.

marked as submitted. Review request for KDE Frameworks and David Edmundson. Changes --- Submitted with commit 702475557d5d2f6680f01169b4e33881be9b35b7 by David Faure on behalf of Xuetian Weng to branch master. Repository: kauth Description --- I'm on Qt 5.6 RC, and just not

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

ction if needed. Diffs (updated) - src/klauncher/klauncher.h 31bfaaa src/klauncher/klauncher.cpp 7ea9da9 Diff: https://git.reviewboard.kde.org/r/127166/diff/ Testing --- Compiles, startup notify works. Thanks, Xuetian Weng ___ Kde-f

Re: Review Request 127261: Fix dead lock when program use kauth exits.

> On March 3, 2016, 7:05 a.m., Martin Gräßlin wrote: > > nice work! I had run into it in the past and didn't succeed investigating > > it. > > Xuetian Weng wrote: > https://bugreports.qt.io/browse/QTBUG-51648 > > As pointed out by Thiago on irc,

Re: Review Request 127261: Fix dead lock when program use kauth exits.

eviewboard.kde.org/r/127261/#review93082 --- On March 2, 2016, 8:58 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Review Request 127271: Disable session restore for kwalletd5

etd/main.cpp 740e670 Diff: https://git.reviewboard.kde.org/r/127271/diff/ Testing --- kwallet-pam back to work. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127261: Fix dead lock when program use kauth exits.

kends/dbus/DBusHelperProxy.cpp 20dad0a Diff: https://git.reviewboard.kde.org/r/127261/diff/ Testing --- Now kded5 can exits upon logout/exit. Tested with kquitapp5 kded5. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-dev

Review Request 127261: Fix dead lock when program use kauth exits.

can exits upon logout/exit. Tested with kquitapp5 kded5. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127201: Fix svg icon path resolving in IconItem

9a7 Diff: https://git.reviewboard.kde.org/r/127201/diff/ Testing --- tested with qmlscene with Plasma.IconItem. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > <https://git.reviewboard.kde.org/r/127201/diff/2/?file=445755#file445755line234> > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > <https://git.reviewboard.kde.org/r/127201/diff/2/?file=445755#file445755line234> > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so

Re: Review Request 127201: Fix svg icon path resolving in IconItem

IconItem. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127201: Fix svg icon path resolving in IconItem

e icon is not rendered with the same svg backend but it will pass for now. - Xuetian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/#review92843 -----

Re: Review Request 127201: Fix svg icon path resolving in IconItem

otests/data/icons/test-theme/index.theme PRE-CREATION autotests/iconitemtest.h 9fd3063 autotests/iconitemtest.cpp f675465 src/declarativeimports/core/iconitem.cpp c65a9a7 Diff: https://git.reviewboard.kde.org/r/127201/diff/ Testing --- tested with qmlscene with Plasma.IconI

Review Request 127201: Fix svg icon path resolving in IconItem

svg?? introduced in https://git.reviewboard.kde.org/r/126557/ Diffs - src/declarativeimports/core/iconitem.cpp 085f284 Diff: https://git.reviewboard.kde.org/r/127201/diff/ Testing --- tested with qmlscene with Plasma.IconItem. Thanks, Xuetian W

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127166/#review92811 --- ping - Xuetian Weng On Feb. 24, 2016, 5:19 a.m., Xuetian

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

gn to it in the function. - Xuetian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127166/#review92707 --- On Feb. 24

Review Request 127166: Fix xcb port of klauncher and clean up the code.

her/klauncher.h 31bfaaa src/klauncher/klauncher.cpp 7ea9da9 Diff: https://git.reviewboard.kde.org/r/127166/diff/ Testing --- Compiles, startup notify works. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-deve

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

emote url in places and try browse some sub folder -> ok Local url in places and try browse some sub folder -> ok Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

t with private interface. - Xuetian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/#review89378 --- On Dec. 12,

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

igator.cpp 848e98b Diff: https://git.reviewboard.kde.org/r/126295/diff/ Testing --- Remote url -> ok Local url -> ok Remote url in places and try browse some sub folder -> ok Local url in places and try browse some sub folder -> ok Thanks, Xuetian Weng _

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

igator.cpp 848e98b Diff: https://git.reviewboard.kde.org/r/126295/diff/ Testing --- Remote url -> ok Local url -> ok Remote url in places and try browse some sub folder -> ok Local url in places and try browse some sub folder -> ok Thanks, Xuetian Weng

Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

N src/filewidgets/kurlnavigator.cpp 848e98b Diff: https://git.reviewboard.kde.org/r/126295/diff/ Testing --- Remote url -> ok Local url -> ok Remote url in places and try browse some sub folder -> ok Local url in places and try browse some sub folder -> ok Thanks, Xuetian Weng _

Re: Review Request 126231: Fix a small artifact of kratingwidget on hidpi

. Now it draws correctly. File Attachments Demonstrate the problem https://git.reviewboard.kde.org/media/uploaded/files/2015/12/03/5fd4f10d-cc2a-49f4-b6b1-ac5ac1d1e9e5__screenshot24.png Thanks, Xuetian Weng ___ Kde-frameworks

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

, star's color becomes lighter. Click and rating becomes 0. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

up, click on 1st star, rating becomes 2. Current rating is 2. hover on the 1st star, half star lights up, click on 1st star, rating becomes 1. Current rating is 1/2. move mouse to the left most edge, star's color becomes lighter. Click and rating becomes 0. Thanks, Xuetian

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

, rating becomes 2. Current rating is 2. hover on the 1st star, half star lights up, click on 1st star, rating becomes 1. Current rating is 1/2. move mouse to the left most edge, star's color becomes lighter. Click and rating becomes 0. Thanks, Xuetian

Review Request 126231: Fix a small artifact of kratingwidget on hidpi

Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

lights up, click on 1st star, rating becomes 1. Current rating is 1/2. move mouse to the left most edge, star's color becomes lighter. Click and rating becomes 0. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kd

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

On Dec. 2, 2015, 4:34 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126222/ >

Review Request 126222: Fix rating widget flickering when selecting rating with mouse

ing(2) setHalfStepsEnabled(false) setMaxRating(1) setHalfStepsEnabled(false) setMaxRating(1) setHalfStepsEnabled(true) setMaxRating(5) setHalfStepsEnabled(true) Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 126164: Request proper dbus name for kioexec

s.txt 91284a3 src/kioexec/main.cpp 68ed374 Diff: https://git.reviewboard.kde.org/r/126164/diff/ Testing --- Dolphin now does not freeze in this case. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 126164: Request proper dbus name for kioexec

rvice name is not added when porting to qt5/kf5. Diffs - src/kioexec/CMakeLists.txt 91284a3 src/kioexec/main.cpp 68ed374 Diff: https://git.reviewboard.kde.org/r/126164/diff/ Testing --- Dolphin now does not freeze in this case. Thanks, Xuetian

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

iewboard.kde.org/r/125885/#review87847 --- On Oct. 30, 2015, 11:26 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 125904: Save proxy url with correct scheme.

make sure that loading url configuration will hide url scheme correctly. Diffs - src/kcms/kio/kproxydlg.cpp c8fd0cd Diff: https://git.reviewboard.kde.org/r/125904/diff/ Testing --- Save socks proxy and ftp proxy will result in "ftp://"; and "socks://". T

Re: Review Request 125904: Save proxy url with correct scheme.

/r/125904/diff/ Testing --- Save socks proxy and ftp proxy will result in "ftp://"; and "socks://". Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125904: Save proxy url with correct scheme.

proxy and ftp proxy will result in "ftp://"; and "socks://". Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

> On Oct. 31, 2015, 8:39 a.m., David Faure wrote: > > This is clearly missing an "else" for other cases like an http proxy, can > > you add it, even without being able to test it? > > > > In any case this is a clear improvement. > > Xuetian Weng wro

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

-------- On Oct. 30, 2015, 11:26 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125885/ > -

Review Request 125885: Support socks5 proxy in KTcpSocket

imap agent, connect through socks5 proxy. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125705: Use LANG for month names in calendar applet

> On Oct. 20, 2015, 9:30 p.m., Albert Astals Cid wrote: > > src/declarativeimports/calendar/calendar.cpp, line 197 > > > > > > uilanguages is not good for direct inputing into QLocale (yes i know, > > it's stupi

Re: Review Request 125705: Use LANG for month names in calendar applet

) <https://git.reviewboard.kde.org/r/125705/#comment59864> This only checks LANG, meanwhile, LC_ALL and LC_MESSAGES, and maybe even LANGUAGE should also be considered. But I guess using the first item from QLocale().uiLanguages() would just work. - Xuetian Weng On Oct. 19, 2015

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

marked as submitted. Review request for KDE Frameworks, Albert Astals Cid and David Faure. Changes --- Submitted with commit 0a39ba6ec01600efeb9e334fa457dd725e2e3749 by David Faure on behalf of Xuetian Weng to branch master. Repository: kservice Description --- In

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

iff: https://git.reviewboard.kde.org/r/125537/diff/ Testing --- Now a sub directory with larger timestamp than parent will not cause ksycoca data being recreated again and again. Thanks, Xuetian Weng ___ Kde-frameworks-devel mailing list Kde-

  1   2   >