D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. wktradew...@gmail.com ... unless you wanted that in the summary? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg, cfeck, ngraham Cc: meven, volkov, cfeck, bruns, ngraham, kde-framewo

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. Updated diff. It's setting the quality now, and added a brief comment. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-

D26648: Improved quality of JPEG thumbnails

chroniceel updated this revision to Diff 73722. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26648?vs=73480&id=73722 REVISION DETAIL https://phabricator.kde.org/D26648 AFFECTED FILES thumbnail/jpegcreator.cpp To: chroniceel, broulik, #frameworks, #v

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. Ping! I think this got buried. Unless someone else is testing this? REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fpri

D26648: Improved quality of JPEG thumbnails

chroniceel edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2,

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. It's not overly scientific, but with this little fix, it can gen ~10 thumbnails a second on my system (1.6 Ghz pentium, ~10MP). This seems on par with png files of a similar size. As far as I can tell, there is not a super huge performance decrease. Please note, I

D26648: Improved quality of JPEG thumbnails

chroniceel updated this revision to Diff 73480. chroniceel added a comment. Less is more, removing the line appears to be a solution as well. Assuming QImageReader uses sane defaults. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26648?vs=73477&id=73480 REVISION DETAIL https://p

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. Okay, removing the line appears to have a similar effect to what I already did. I checked over on the imagecreator.cpp file, which appears to handle the thumbnailing of most other image types, and despite also using a QImageReader object, it does not call setQuali

D26648: Improved quality of JPEG thumbnails

chroniceel edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg Cc: bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde,

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. I'm going to delete that line and see what happens. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D26648 To: chroniceel, broulik, #frameworks, #vdg Cc: bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGa

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. It appears to me that the setQuality() function is meant to, in this use case, to simply decide what downscaler to use. Higher values mean better quality downscaling. Sorry about the images, I did not realize I should have labelled them better. They are named

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. Excerpt from the QImageReader class documentation, for the function setQuality(): "In case of scaled image reading, the quality setting may also influence the tradeoff level between visual quality and execution speed of the scaling algorithm." A compromi

D26648: Improved quality of JPEG thumbnails

chroniceel added a comment. This does not affect the size of the created thumbnail, as all thumbnails are stored as png images regardless of source image type. This simply allows the thumbnailer to downscale the image without the artifacting displayed in the screenshots. I have checked and d

D26648: Improved quality of JPEG thumbnails

chroniceel created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. chroniceel requested review of this revision. REVISION SUMMARY BUG: 411262 Simple tweak to increase quality of JPEG thumbnails. For some reason the thumb