D22365: KNotification macOS native support by NSNotificationCenter

Inoki closed this revision. Inoki added a comment. Landed: https://cgit.kde.org/knotifications.git/commit/?id=58caf6ad5b48aa573a6d3b8d3e23e07afce8a03f REVISION DETAIL https://phabricator.kde.org/D22365 To: Inoki, rjvbb, nicolasfella Cc: lnj, nicolasfella, broulik, kde-frameworks-devel, L

D22365: KNotification macOS native support by NSNotificationCenter

Inoki added a comment. Updating with new incoming code. Will try landing it this week REVISION DETAIL https://phabricator.kde.org/D22365 To: Inoki, rjvbb, nicolasfella Cc: lnj, nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22365: KNotification macOS native support by NSNotificationCenter

Inoki added a comment. In D22365#538245 , @lnj wrote: > There's something for notifications for iOS and macOS here: https://developer.apple.com/documentation/foundation/nsnotification > Would this patch already work on iOS or could a common AP

D22365: KNotification macOS native support by NSNotificationCenter

Inoki added a comment. In D22365#532294 , @rjvbb wrote: > I haven't been able to give this much attention, sorry. > > After backporting the patch to OS X 10.9 it does work so I presume it'll work even better with the full functionality availa

D22365: KNotification macOS native support by NSNotificationCenter

Inoki marked 5 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D22365 To: Inoki, rjvbb Cc: nicolasfella, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22365: KNotification macOS native support by NSNotificationCenter

Inoki updated this revision to Diff 62797. Inoki added a comment. Add icon from theme as an alternative while pixmap not set CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22365?vs=62414&id=62797 REVISION DETAIL https://phabricator.kde.org/D22365 AFFECTED FILES src/CMakeLists.t

D22365: KNotification macOS native support by NSNotificationCenter

Inoki updated this revision to Diff 62414. Inoki marked 2 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22365?vs=61487&id=62414 REVISION DETAIL https://phabricator.kde.org/D22365 AFFECTED FILES src/CMakeLists.txt src/knotificationmanager.cpp src/notify

D22365: KNotification macOS native support by NSNotificationCenter

Inoki marked 16 inline comments as done. Inoki added inline comments. INLINE COMMENTS > broulik wrote in notifybymacosnotificationcenter.h:14 > Add `override` Which one? > broulik wrote in notifybymacosnotificationcenter.mm:61 > We have a "default action" concept now where clicking the popup it

D22365: KNotification macOS native support by NSNotificationCenter

Inoki created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Inoki requested review of this revision. REVISION SUMMARY Add macOS native support to KNotification REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D