Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

2015-10-18 Thread Thomas Eschenbacher
> On Okt. 18, 2015, 8:49 vorm., Albert Astals Cid wrote: > > Two more things: > > * I think this should only be done if translators() is empty > > * You should document this is going to fill in KAboutData::translators if > > empty with those values So what about this approach: We just remove

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

2015-10-18 Thread Thomas Eschenbacher
> On Okt. 18, 2015, 6:50 vorm., Thomas Eschenbacher wrote: > > This should work, but IMHO it does not go far enough. I can see many more > > calls to QCoreApplication::translate(...) with user defined content in this > > file (kaboutdata.cpp), which is also affected, a

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

2015-10-17 Thread Thomas Eschenbacher
application name as "domain" paramter of dcgettext). But that was only a quick experiment, maybe someone knows a more elegant way to solve this... - Thomas Eschenbacher On Okt. 18, 2015, 2:13 vorm., Michael Pyne wrote: > > --