Re: Review Request 118680: Reorder Tests

02885e7101bfd4239d3fb64f2940cb80933570b7 Diff: https://git.reviewboard.kde.org/r/118680/diff/ Testing --- All tests still pass Thanks, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 118680: Reorder Tests

02885e7101bfd4239d3fb64f2940cb80933570b7 Diff: https://git.reviewboard.kde.org/r/118680/diff/ Testing --- All tests still pass Thanks, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 118680: Reorder Tests

> > > > If it's for the target_include_directories, you can still do it to an > > ecm_add_tests created target. > > Thomas Braxton wrote: > No, because it depends on KConfigUtils, so it should be after > test_kconfigutils. > > Aleix Pol Gonza

Re: Review Request 118666: Simple Cleanups

Diff: https://git.reviewboard.kde.org/r/118666/diff/ Testing --- All tests still pass Thanks, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118680: Reorder Tests

n automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118680/#review59855 ------- On June 11, 2014, 11:04 p.m., Thomas Braxton wrote: > > --- > Th

Re: Review Request 118666: Simple Cleanups

://git.reviewboard.kde.org/r/118666/diff/ Testing --- All tests still pass Thanks, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118680: Reorder Tests

--- All tests still pass Thanks, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118666: Simple Cleanups

, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118666: Simple Cleanups

--------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118666/#review59803 --- On June 11, 2014, 1:59 p.m., Thomas Braxton wrote: > > ---

Review Request 118666: Simple Cleanups

829d35e61da3d303539044d0dc652cc99dec35a2 src/kconf_update/kconfigutils.cpp f2663e1316ec2cdbef303385787d14406e02f4a1 Diff: https://git.reviewboard.kde.org/r/118666/diff/ Testing --- All tests still pass Thanks, Thomas Braxton ___ Kde-frameworks-devel

Re: Review Request 118339: Update usage of QVariant::type() for Qt5.

: https://git.reviewboard.kde.org/r/118339/diff/ Testing --- All tests pass. Thanks, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118339: Update usage of QVariant::type() for Qt5.

, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118332: Update usage of QVariant::type() for Qt5.

warnings about 38 not being a member of QVariant::Type. Diffs - src/core/kconfiggroup.cpp bce9e69d518ce987c4cfaf0f9dd8a2d1cbac6f5b Diff: https://git.reviewboard.kde.org/r/118332/diff/ Testing --- All tests still pass. Thanks, Thomas Braxton

Review Request 118332: Update usage of QVariant::type() for Qt5.

/kconfiggroup.cpp bce9e69d518ce987c4cfaf0f9dd8a2d1cbac6f5b Diff: https://git.reviewboard.kde.org/r/118332/diff/ Testing --- All tests still pass. Thanks, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 118039: Simplify KConfig::readEntry/writeEntry

otests/kconfigtest.cpp 2768318 src/core/kconfiggroup.h 1bcce58 Diff: https://git.reviewboard.kde.org/r/118039/diff/ Testing --- all tests still pass. Thanks, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 118039: Simplify KConfig::readEntry/writeEntry

pdated) - autotests/kconfigtest.cpp 2768318 src/core/kconfiggroup.h 1bcce58 Diff: https://git.reviewboard.kde.org/r/118039/diff/ Testing --- all tests still pass. Thanks, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-fram

Re: Review Request 118039: Simplify KConfig::readEntry/writeEntry

otests/kconfigtest.cpp 2768318 src/core/kconfiggroup.h 1bcce58 Diff: https://git.reviewboard.kde.org/r/118039/diff/ Testing --- all tests still pass. Thanks, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 118039: Simplify KConfig::readEntry/writeEntry

otests/kconfigtest.cpp 2768318 src/core/kconfiggroup.h 1bcce58 Diff: https://git.reviewboard.kde.org/r/118039/diff/ Testing (updated) --- all tests still pass. Thanks, Thomas Braxton ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

tps://git.reviewboard.kde.org/r/116075/#comment35725> couldn't this be replaced with m_items.removeOne(ours) ? - Thomas Braxton On Feb. 26, 2014, 8:09 a.m., Martin Gräßlin wrote: > > --- > This is an automatically genera