sraizada added a comment.
The issue with matching unbalanced braces (picture in previous comment) also
happens in unmodified KWrite, so it doesn't seem to be an issue with this
revision.
This fails test 49 - kateview_test; but checking out ktexteditor from git and
then running make/make in
sraizada updated this revision to Diff 34333.
sraizada added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel,
kwrite-devel; removed: Frameworks.
Improved patch, closing brackets get eaten properly in all cases I tested.
The only issue I found is that matc
sraizada added a comment.
I only use Kate/KWrite so didn't test it on the others previously - sorry.
It actually only works in Kate and KWrite, and has no effect on
Kile/KDevelop. KDevelop is obviously doing some special stuff, but visually the
Kile autocompletion seems identical to the one
sraizada updated this revision to Diff 33884.
sraizada added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel,
kwrite-devel; removed: Frameworks.
Removed unnecessary modifications to code
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabri
sraizada added a project: KTextEditor.
sraizada added a subscriber: KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D12768
To: sraizada, #ktexteditor
Cc: #ktexteditor, #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking,
head7, cullmann, kfunk, s
sraizada created this revision.
sraizada added a reviewer: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
sraizada requested review of this revision.
REVISION SUMMARY
When at the first autocomplete result, pressing up
sraizada created this revision.
sraizada added a reviewer: KTextEditor.
sraizada added a project: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
sraizada requested review of this revision.
REVISION SUMMARY
With autobra
sraizada added a comment.
Would it be appropriate to add this as a config option in the settings?
Because to me, keeping the sort of whitespace you describe seems like the
better behavior:
doSomething(a, b, |
^ is correct. But obviously there are differing opinions on this, and a
setting
sraizada added a comment.
Forgot to put this in the first submission: it fails test 66 vimode_keys, I
believe this may be related to bug 392858 - vi mode :q (quit) command works in
Kate but not KWrite https://bugs.kde.org/show_bug.cgi?id=392858
Every other test passes.
REPOSITORY
R39 KTe
sraizada created this revision.
sraizada added a reviewer: KTextEditor.
sraizada added a project: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
sraizada requested review of this revision.
REVISION SUMMARY
When the 're
10 matches
Mail list logo
