steffenh updated this revision to Diff 58241.
steffenh added a comment.
change name to KTouchGesture
add a private class for every exported class
remove unused code
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21028?vs=57584&id=58241
BRANCH
steffenh added a comment.
Hi @ngraham,
thanks for the link, I see KGesture is already used. I hope KGestureHandler
is not too similar
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D21028
To: steffenh, #frameworks
Cc: ngraham, apol, nicolasfella, cfeck,
steffenh added a comment.
Hi @nicolasfella,
Ok, I need a new name, perhaps KGesture ?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D21028
To: steffenh, #frameworks
Cc: apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns
steffenh added a comment.
Hi @apol,
Thanks for your time to look at my code. I know, I'am not good at this, so if
you can point me at my errors I will try to correct this.
INLINE COMMENTS
> apol wrote in koneandtwofingerswipe.h:36
> Why is this commented out?
Oops this should not be he
steffenh created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
steffenh requested review of this revision.
REVISION SUMMARY
This patch adds the gestures and handler class from gwenview to
KWidgetsAddons, so another program you can use this.