Re: Review Request 123706: Add session management for KMainWindow

marked as submitted. Review request for KDE Frameworks and Rex Dieter. Changes --- Submitted with commit fa86f6e4afd4a4f32d297f271d3daececc6c0ba4 by Rex Dieter on behalf of Stefan Becker to branch master. Bugs: 346768 https://bugs.kde.org/show_bug.cgi?id=346768 Repository: kxmlgui

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

marked as submitted. Review request for KDE Frameworks and Rex Dieter. Changes --- Submitted with commit 9978cfd5ccd18509dd514b3a7ada8c158c209de1 by Rex Dieter on behalf of Stefan Becker to branch master. Bugs: 346768 https://bugs.kde.org/show_bug.cgi?id=346768 Repository: kconfig

Re: Review Request 123706: Add session management for KMainWindow

/123706/diff/ Testing --- On F22 with kwrite & konsole Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

sole Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123707: Set session manager discard command

& konsole, ksmserver and "Save Session..." Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123706: Add session management for KMainWindow

: 123706 Diffs (updated) - src/kmainwindow.cpp 15eecb7 Diff: https://git.reviewboard.kde.org/r/123706/diff/ Testing --- On F22 with kwrite & konsole Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

--- On F22 with kwrite & konsole Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123707: Set session manager discard command

- F22 kwrite & konsole, ksmserver and "Save Session..." Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123706: Forward QSessionManager to KConfigGui

stored to disk we have to call sync() on the object after the application has updated it. Diffs (updated) - src/kmainwindow.cpp 15eecb7 Diff: https://git.reviewboard.kde.org/r/123706/diff/ Testing --- On F22 with kwrite & konsole Thanks, Stefan Be

Re: Review Request 123707: Set session manager discard command

ksmserver and "Save Session..." Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

& konsole Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123706: Forward QSessionManager to KConfigGui

. To make sure that the data is stored to disk we have to call sync() on the object after the application has updated it. Diffs (updated) - src/kmainwindow.cpp 15eecb7 Diff: https://git.reviewboard.kde.org/r/123706/diff/ Testing --- On F22 with kwrite & konsole Thanks, St

Re: Review Request 123707: Set session manager discard command

& konsole, ksmserver and "Save Session..." Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

/123705/diff/ Testing --- On F22 with kwrite & konsole Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123705: Add 2nd variant for KConfigGui::sessionConfig()

Config > > instance? Then we wouldn't have this "lose unsaved changes" code path. Or > > is the idea that multiple parts of the code could connect to the qApp > > signal, so they should share the same KConfig instance? > > Stefan Becker wrote: > I und

Re: Review Request 123705: Add 2nd variant for KConfigGui::sessionConfig()

automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/#review80136 --- On May 10, 2015, 10:30 a.m., Stefan Becker wrote: > > --- > Thi

Re: Review Request 123707: Set session manager discard command

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/#review80138 --- On May 10, 2015, 10:47 a.m., Stefan Becker wrote:

Re: Review Request 123706: Forward QSessionManager to KConfigGui

automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/#review80164 --- On May 10, 2015, 2:39 p.m., Stefan Becker wrote: > > ---

Re: Review Request 123706: Forward QSessionManager to KConfigGui

nsole Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123707: Set session manager discard command

Testing --- F22 kwrite & konsole, ksmserver and "Save Session..." Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123705: Add 2nd variant for KConfigGui::sessionConfig()

anks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123706: Forward QSessionManager to KConfigGui

. Diffs (updated) - src/kmainwindow.cpp 15eecb7 src/kmainwindow_p.h 8204ce1 Diff: https://git.reviewboard.kde.org/r/123706/diff/ Testing --- On F22 with kwrite & konsole Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list

Review Request 123707: Set session manager discard command

Testing --- F22 kwrite & konsole, ksmserver and "Save Session..." Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123706: Forward QSessionManager to KConfigGui

://git.reviewboard.kde.org/r/123706/diff/ Testing --- On F22 with kwrite & konsole Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123705: Add 2nd variant for KConfigGui::sessionConfig()

. Diffs - src/gui/kconfiggui.h 173400f src/gui/kconfiggui.cpp 0048c60 Diff: https://git.reviewboard.kde.org/r/123705/diff/ Testing --- On F22 with kwrite & konsole Thanks, Stefan Becker ___ Kde-frameworks-devel mailing list