https://git.reviewboard.kde.org/r/129170/diff/
Testing
---
I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps we'll
need more tests, but I'm not sure how to make an archive to fail in some
specific way aside from the very basics ("file not found", etc.).
Thanks,
Romário Rios
; > Neither ATime nor CTime is actually used in this code, feel free to remove
> > it, maybe in a commit that you would rebase this one upon, or I can do it
> > after you push. So at a minimum, replace MTime with "modification time",
> > fix @since, then pus
; > Neither ATime nor CTime is actually used in this code, feel free to remove
> > it, maybe in a commit that you would rebase this one upon, or I can do it
> > after you push. So at a minimum, replace MTime with "modification time",
> > fix @since, then pus
. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100629
-------
On Nov. 1, 2016, 8:10 p.m., Romário Rios wrote:
>
> ---
> This is an automatic
7;ll
need more tests, but I'm not sure how to make an archive to fail in some
specific way aside from the very basics ("file not found", etc.).
Thanks,
Romário Rios
atically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100413
-------
On Nov. 1, 2016, 8:10 p.m., Romário Rios wrote:
>
> ---
> This is an automatically generated
e
specific way aside from the very basics ("file not found", etc.).
Thanks,
Romário Rios
Romário
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100021
---
On Oct. 15, 2016, 3:08 a.m., Romár
ile a bug report at https://bugs.kde.org
I think this implies the application using the library is a KDE App, which
isn't necessarily the case.
- Romário
---
This is an automatically generated e-mail. To reply, vis
0/#review6
---
On Oct. 15, 2016, 3:08 a.m., Romário Rios wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.re
e from the very basics ("file not found", etc.).
Thanks,
Romário Rios
some
specific way aside from the very basics ("file not found", etc.).
Thanks,
Romário Rios
meworks/Frameworks_Localization_Policy#Qt_installation_code
Thanks, Luigi. I'll work on that and update the patch.
- Romário
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org
sting
---
I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps we'll
need more tests, but I'm not sure how to make an archive to fail in some
specific way aside from the very basics ("file not found", etc.).
Thanks,
Romário Rios
For true platform independence, CMake provides a list of commands
that can be used on all systems.
- Romário
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125941/#review88
org/r/125941/diff/
Testing
---
The tests run and show that KCompressionDevice works properly with QBuffer when
used with KTar
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/lis
hanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
with QBuffer when
used with KTar
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/125974/diff/
Testing
---
Makes the tests from review #125941 pass
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125974/#review88126
-------
On Nov. 6, 2015, 2:52 a.m., Romário Rios wrote:
>
> ---
> This
; what if this is seeking backward? That's not possible on a sequential
> > device, so my advice is, forget using a sequential device here, download to
> > a temp file.
>
> Romário Rios wrote:
> Actually, this is irrelevant to the issue. I reverted this code back
oard.kde.org/r/125974/#review88078
---
On Nov. 6, 2015, 2:52 a.m., Romário Rios wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.
#125941 pass
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
------
On Nov. 4, 2015, 9:34 p.m., Romário Rios wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125941/
> --
tps://git.reviewboard.kde.org/r/125941/#comment60401>
I don't believe it can. It can do the opposite -- CompressionType by
filename or mimetype --, but not this.
- Romário Rios
On Nov. 4, 2015, 2:08 a.m., Romário Rios wrote:
>
>
n and show that KCompressionDevice isn't working as expected
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
tests/kcompressiondevicetest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/125941/diff/
Testing
---
The tests run and show that KCompressionDevice isn't working as expected
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-dev
387
src/karchive.cpp 344cba8
Diff: https://git.reviewboard.kde.org/r/124165/diff/
Testing
---
Seems to work for all files (tested with xz and zip files containing
executables, directories, text, etc.).
Thanks,
Romário Rios
___
Kde-framew
es (tested with xz and zip files containing
executables, directories, text, etc.).
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
688:27: error: invalid conversion
from 'int' to 'QFileDevice::Permission' [-fpermissive]
/home/luizromario/karchive/src/karchive.cpp:691:27: error: invalid conversion
from 'int' to 'QFileDevice::Permission' [-fpermissive]
```
- Romário
-
o work for all files (tested with xz and zip files containing
executables, directories, text, etc.).
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ba8
Diff: https://git.reviewboard.kde.org/r/124165/diff/
Testing
---
Seems to work for all files (tested with xz and zip files containing
executables, directories, text, etc.).
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-
, etc.).
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
n the KArchiveFile to the
QFile being copied.
Diffs
-
src/karchive.cpp 344cba8
Diff: https://git.reviewboard.kde.org/r/124165/diff/
Testing
---
Seems to work for all files (tested with xz and zip files containing
executables, directories, text, etc.).
Thanks,
Romário
/CMakeLists.txt 5a37efa
tier1/kwidgetsaddons/tests/CMakeLists.txt 9738c6c
Diff: http://git.reviewboard.kde.org/r/111319/diff/
Testing
---
Compiles, test runs fine.
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-framework
necessary in
that case -- bg1 changes in the switch right below it. But, yeah, changing the
coding style is also not very nice, so, reverting.
- Romário
---
This is an automatically generated e-mail. To reply, visit:
http:
/kwidgetsaddons/src/kmessagewidget.cpp PRE-CREATION
tier1/kwidgetsaddons/tests/CMakeLists.txt 9738c6c
tier1/kwidgetsaddons/tests/kmessagewidgettest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111319/diff/
Testing
---
Compiles, test runs fine.
Thanks
e they're being deprecated -- I assume that's
OK.
Thanks,
Romário Rios
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
38 matches
Mail list logo
