Re: Review Request 128277: Fix unsafe KDirModelDirNode* casts

2016-07-01 Thread Rob Wu
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 04b0681d0c1f7e294bae8039cf2a8b720ed919f0 by Aleix Pol on behalf of Rob Wu to branch master. Repository: kio Description --- Replace two isDir debug assertions with conditionals, because there

Re: Review Request 128277: Fix unsafe KDirModelDirNode* casts

2016-06-27 Thread Rob Wu
view96881 --- On June 23, 2016, 4:55 p.m., Rob Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Review Request 128277: Fix unsafe KDirModelDirNode* casts

2016-06-23 Thread Rob Wu
ows the files in the directory ("filename.tex"). 4. Press arrow down. Now the filename will be matched and NOTHING should happen. Before this patch, step 4 would crash; This is a reduced test case based on a crash when I tried to save my work in TexMaker's (Save As dialog). Tha