pgkos added a comment.
In my opinion, roundToIconSize should operate on scaled units - it is used
multiple times in a few plasmoids - all calls from them to roundToIconSize
assume it will operate on scaled units.
The method, as it is now, is useless, because QML code has no access to
KI
pgkos updated this revision to Diff 26878.
pgkos added a comment.
This is a simpler implementation - the diff changes roundToIconSize so it
uses scaled units.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7849?vs=19612&id=26878
REVISIO
pgkos added a comment.
@anthonyfieroni my first version of the diff changed only the tray icon QML
file, but I think that it is better to fix it in the plasma framework, as that
function is used in multiple other places and there is the same problem with
wrongly sized icons on hidpi screens.
pgkos added a comment.
@broulik consider this case:
The tray icons' size is defined by default in
`org.kde.plasma.private.systemtray/contents/config/main.xml` to `smallMedium`,
which means 22 pixels on a 96-dpi screen. On a 192-dpi screen, the icons' real
size is 44 pixels.
Now, in `o
pgkos updated this revision to Diff 19612.
pgkos added a comment.
Fixed the previous diff.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7849?vs=19592&id=19612
REVISION DETAIL
https://phabricator.kde.org/D7849
AFFECTED FILES
src/declarativeimports/core/units.cpp
src/declarat
pgkos updated this revision to Diff 19592.
pgkos changed the repository for this revision from R120 Plasma Workspace to
R242 Plasma Framework (Library).
pgkos added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
Edited the
