D27148: update d->m_file in ReadOnlyPart::setUrl()

pdabrowski abandoned this revision. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27148 To: pdabrowski, elvisangelaccio, ngraham, #frameworks, dfaure Cc: ahmadsamir, marten, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27148: update d->m_file in ReadOnlyPart::setUrl()

pdabrowski marked an inline comment as done. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27148 To: pdabrowski, elvisangelaccio, ngraham, #frameworks, dfaure Cc: marten, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27148: update d->m_file in ReadOnlyPart::setUrl()

pdabrowski updated this revision to Diff 75015. REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27148?vs=74970&id=75015 REVISION DETAIL https://phabricator.kde.org/D27148 AFFECTED FILES src/readonlypart.cpp src/readonlypart.h To: pdabrowski, elvisangelac

D27148: update d->m_file in ReadOnlyPart::setUrl()

pdabrowski added inline comments. INLINE COMMENTS > readonlypart.cpp:80 > > +QUrl ReadOnlyPart::mostLocalUrl(QUrl url) const { > +KIO::StatJob* statJob = KIO::mostLocalUrl(url); TODO: mostLocalUrl(const QUrl &url) REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27

D27148: update d->m_file in ReadOnlyPart::setUrl()

pdabrowski added a comment. In D27148#605830 , @marten wrote: > Yes, I'd concluded that the real place to fix the problem was at the KParts level, but not being a KParts expert wanted to leave that decision to its maintainers. +1 for the elegan

D27148: update d->m_file in ReadOnlyPart::setUrl()

pdabrowski created this revision. pdabrowski added reviewers: elvisangelaccio, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pdabrowski requested review of this revision. REVISION SUMMARY Properly update d->m_file so it can be safely used later in