D15350: Unit tests for the R indent script

devillemereuil added a comment. Yes, let's do that for now. I'll get an account if this becomes a habit. Thanks for your help! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15350 To: devillemereuil, #ktexteditor, #rkward, cullmann Cc: cullmann, kwrite-devel, kd

D15350: Unit tests for the R indent script

devillemereuil added a comment. I thought this phabricator review served as a push request? How can I push the revision myself? Can I push directly on annongit.kde.org? (Sorry for being yet again a newb!) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15350 To:

D15350: Unit tests for the R indent script

devillemereuil created this revision. devillemereuil added reviewers: KTextEditor, RKWard. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. devillemereuil requested review of this revision. REVISION SUMMARY A series of unit tests as was reque

D15349: Update of the R indent script

devillemereuil created this revision. devillemereuil added reviewers: KTextEditor, RKWard. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. devillemereuil requested review of this revision. REVISION SUMMARY Changing the licence and Kate versi

D12587: Indentation script for R

devillemereuil added a comment. Will do. Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemereuil, #ktexteditor, #rkward, cullmann Cc: kwrite-devel, kde-frameworks-devel, cullmann, tfry, dhaumann, michaelh, kevinapavew, ngraham, bruns, dem

D12587: Indentation script for R

devillemereuil added a comment. I... git cloned ktexteditor and ran `cmake .`? Is there a better way? Sorry, I'm a real newb in this as you can probably tell! I'm not a dev by training. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemereuil, #kt

D12587: Indentation script for R

devillemereuil added a comment. OK. So, that'll require compile ktexteditor from source. I should be able to manage that (I guess?). I'll report here if it gives me too many headaches. I tried today, but gave up because of an issue with ECM (?) version. I got: Could not find a configur

D12587: Indentation script for R

devillemereuil added a comment. That's the thing: I don't know how to run the test. If it requires dealing with cmake and stuff, that's take me a while to figure out. Is there any simple documentation about it? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D1258

D12587: Indentation script for R

devillemereuil added a comment. So, basically, I just write a bunch of tests, commit them here and we'll debug them if needed from here? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemereuil, #ktexteditor, #rkward, cullmann Cc: kwrite-devel, kd

D12587: Indentation script for R

devillemereuil added a comment. Say that I have the files for a unit test (origin, input.js and expected). How can I check the code for the unit test? Is there a way to simply execute the javascript code and verify it does what I expect? It would be a shame to have the unit test fail because

D12587: Indentation script for R

devillemereuil added a comment. I might get to that around September (no promise). If people are willing to help, my not-unit-at-all test code for indentation can be found here: https://github.com/devillemereuil/rindent/blob/master/example.R Automatic indent should not impact the code (

D12587: Indentation script for R

devillemereuil added a comment. Just to say: this didn't fall off my radar. I'm just incredibly busy nowadays and it never quite make it to the top of my todo list... But I think about doing it regularly, which is a good sign it'll happen! REPOSITORY R39 KTextEditor REVISION DETAIL http

D12587: Indentation script for R

devillemereuil added a comment. I will have a go at it. It doesn't seem very complicated indeed, but I just don't have much time right now for this. @tfry I'm not sure what your pseudo-code is intended to replace? The parts using countClosing? FYI, these snippets of code were copied from

D12587: Indentation script for R

devillemereuil added a comment. In D12587#255484 , @dhaumann wrote: > I think this is very cool. But there is one thing we require for new indenters: unit tests. > > There is a subfolder autotest in the KTextEditor git module. Could you have

D12587: Indentation script for R

devillemereuil created this revision. devillemereuil added reviewers: KTextEditor, RKWard. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. devillemereuil requested review of this revision. REVISION SUMMARY This is a javascript inden