D22653: Add view-barcode-qr icons

lavender added a comment. In D22653#505659 , @ndavis wrote: > I try not to be too aggressive with optimization when it comes to diffs from other people because the process of making an icon is currently quite tedious and the optimizations

D22653: Add view-barcode-qr icons

lavender added a comment. Functionally it looks good to me, there are a few improvements/optimizations that can be made for example 16 and 22 have unnecessary attributes such as: fill="currentColor" style="fill:currentColor; And the 32 one has a transform that can be applied:

D22653: Add view-barcode-qr icons

lavender added a comment. I noticed that only the 22px icons use the viewbox, is this intentional? The validator I used complains that: Error: Attribute paint-order not allowed on SVG element path at this point. From line 7, column 5; to line 7,

D21378: Make Breeze Light/Dark use more system colors

lavender added a comment. In D21378#469640 , @filipf wrote: > In D21378#469611 , @ndavis wrote: > > > In D21378#469607 , @filipf wrote: > > > > > So I h

D21378: Make Breeze Light/Dark use more system colors

lavender added a comment. In D21378#469517 , @mart wrote: > the idea is kinda nice and with some schemes it will work just perfect... > however i think it risks a lot of having loss in contrast on certain color schems with your patch try for i

D21378: Make Breeze Light/Dark use more system colors

lavender added a comment. Tested and it looks good to me REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21378 To: ndavis, #vdg, #plasma Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns