Re: Review Request 125332: Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.

s://git.reviewboard.kde.org/r/125332/#review85715 --- On Sept. 21, 2015, 12:41 nachm., Patrick von Reth wrote: > >

Review Request 125332: Use the more advanced version of uriencode.cmake from kdoctools which supports Windows.

: https://git.reviewboard.kde.org/r/125332/diff/ Testing --- Windows Thanks, Patrick von Reth ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124736: Add Windows support.

marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit ed118d2107784277a9772cab3bb9bada988da09e by Patrick von Reth to branch master. Repository: kapidox Description --- We have to call python with native Windows paths. We need to

Re: Review Request 124736: Add Windows support.

be reviewed. - Patrick --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124736/#review83860 --- On Aug. 14, 2015, 1:29 p.m

Review Request 124736: Add Windows support.

c1c5e2fe98d95f7a9afd0a7ebf951febdd03961f src/kapidox/generator.py 39c14e29c8f9d35709ca7a912a3b5b9cc456a0e6 Diff: https://git.reviewboard.kde.org/r/124736/diff/ Testing --- Windows Thanks, Patrick von Reth ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On April 3, 2015, 3:58 nachm., Andrius da Costa Ribas wrote: > > cmake/uriencode.cmake, line 15 > > > > > > I've tried changing this to: > > > > execute_process(COMMAND perl -MURI::Escape -e "print > >

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/#review70191 --- Ship it! Ship It! - Patrick von Reth On Nov. 10, 2014, 2

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

> On Nov. 10, 2014, 2:05 p.m., Patrick von Reth wrote: > > Yes as the files include export macros compiling them into an another > > lib/exe will break the build. > > As those where already part of a dll I thought I could just link the dll. I > > tested it o

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

another lib/exe will break the build. As those where already part of a dll I thought I could just link the dll. I tested it on Windows and it build fine. What was the isseu on linux? - Patrick von Reth On Nov. 10, 2014, 1:50 p.m., Milian Wolff wrote

Re: Review Request 118162: Make sure to use the absolute file path for test files.

Diff: https://git.reviewboard.kde.org/r/118162/diff/ Testing --- Windows Thanks, Patrick von Reth ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118162: Make sure to use the absolute file path for test files.

, Patrick von Reth ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/#review58007 --- Ship it! Ship It! - Patrick von Reth On May 15, 2014, 2

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/#review58006 --- Ship it! Ship It! - Patrick von Reth On May 15, 2014, 3

Re: Review Request 118101: fixed windows build

/networking_win.cpp ec16cde8fa8fe1aabb94d5ac6fdebbc17a32b993 tests/CMakeLists.txt 1297013f7afc933dbc6ff7458601a6c7802c0658 Diff: https://git.reviewboard.kde.org/r/118101/diff/ Testing --- Windows mingw Thanks, Patrick von Reth ___ Kde-frameworks

Re: Review Request 118111: adapt to ecm_add_tests

, some tests fail but they will need porting Thanks, Patrick von Reth ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118111: adapt to ecm_add_tests

Thanks, Patrick von Reth ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118101: fixed windows build

----- On May 12, 2014, 3:43 p.m., Patrick von Reth wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118101/ > -

Re: Review Request 118111: adapt to ecm_add_tests

it: https://git.reviewboard.kde.org/r/118111/#review57858 ----------- On May 13, 2014, 8:36 a.m., Patrick von Reth wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 118111: adapt to ecm_add_tests

: kdelibs4support Description --- adapt to ecm_add_tests Diffs - autotests/CMakeLists.txt e9a0421e734de72eff9bc29a7f28201116c240f6 Diff: https://git.reviewboard.kde.org/r/118111/diff/ Testing --- windows, some tests fail but they will need porting Thanks, Patrick von Reth

Review Request 118101: fixed windows build

1297013f7afc933dbc6ff7458601a6c7802c0658 Diff: https://git.reviewboard.kde.org/r/118101/diff/ Testing --- Windows mingw Thanks, Patrick von Reth ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 117965: use the correct global variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/#review57201 --- Ship it! Ship It! - Patrick von Reth On May 2, 2014, 10

Re: Review Request 117965: use the correct global variables

> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The

Re: Review Request 117962: forward declare specialisation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117962/#review57184 --- Ship it! Ship It! - Patrick von Reth On May 2, 2014, 9:17

Re: Review Request 117961: remove several warnings on mingw

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117961/#review57183 --- Ship it! Ship It! - Patrick von Reth On May 2, 2014, 9:16

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

> On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: > > Until now we had no problems with the data installed to bin/../share and > > this setup would make it impossible to have multiple independent kde > > setups on one system. > > Alexander Richardson wrote: &

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

/../share and this setup would make it impossible to have multiple independent kde setups on one system. - Patrick von Reth On Jan. 22, 2014, 1:56 a.m., Alexander Richardson wrote: > > --- > This is an automatically generated e

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/#review43369 --- please use winsock2.h instead of winsock.h - Patrick von Reth

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

ttp://git.reviewboard.kde.org/r/108845/#comment24421> gcc will warn about undefed _MSVC_VER - Patrick von Reth On Feb. 8, 2013, 1:09 a.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply